Re: [PATCH] drm/ttm: cleanup BO size handling v3

2020-12-14 Thread Christian König
Turned out I did test it, but then forgot to do git add to the changes before pushing It was a really long day/week/year :) Christian. Am 14.12.20 um 17:55 schrieb Daniel Vetter: I think you forgot to compile test with amdkfd :-) drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In funct

Re: [PATCH] drm/ttm: cleanup BO size handling v3

2020-12-14 Thread Daniel Vetter
I think you forgot to compile test with amdkfd :-) drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function ‘add_bo_to_vm’: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:456:37: error: ‘struct ttm_resource’ has no member named ‘size’ 456 | unsigned long bo_size = bo->tbo.mem.size; |

[PATCH] drm/ttm: cleanup BO size handling v3

2020-12-10 Thread Christian König
Based on an idea from Dave, but cleaned up a bit. We had multiple fields for essentially the same thing. Now bo->base.size is the original size of the BO in arbitrary units, usually bytes. bo->mem.num_pages is the size in number of pages in the resource domain of bo->mem.mem_type. v2: use the G

Re: [PATCH] drm/ttm: cleanup BO size handling v2

2020-12-09 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20201209] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.10-rc7] [If your

Re: [PATCH] drm/ttm: cleanup BO size handling v2

2020-12-09 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20201209] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.10-rc7] [If your

Re: [PATCH] drm/ttm: cleanup BO size handling v2

2020-12-09 Thread Daniel Vetter
On Wed, Dec 9, 2020 at 3:10 PM Christian König wrote: > > Based on an idea from Dave, but cleaned up a bit. > > We had multiple fields for essentially the same thing. > > Now bo->base.size is the original size of the BO in > arbitrary units, usually bytes. > > bo->mem.num_pages is the size in numb

[PATCH] drm/ttm: cleanup BO size handling v2

2020-12-09 Thread Christian König
Based on an idea from Dave, but cleaned up a bit. We had multiple fields for essentially the same thing. Now bo->base.size is the original size of the BO in arbitrary units, usually bytes. bo->mem.num_pages is the size in number of pages in the resource domain of bo->mem.mem_type. v2: use the G

Re: [PATCH] drm/ttm: cleanup BO size handling

2020-12-08 Thread Huang Rui
On Tue, Dec 08, 2020 at 12:33:00AM +0800, Christian König wrote: > Based on an idea from Dave, but cleaned up a bit. > > We had multiple fields for essentially the same thing. > > Now bo->size is the original size of the BO in arbitrary > units, usually bytes. > > bo->mem.num_pages is the size i

Re: [PATCH] drm/ttm: cleanup BO size handling

2020-12-07 Thread Christian König
Am 07.12.20 um 20:33 schrieb Daniel Vetter: On Mon, Dec 7, 2020 at 5:33 PM Christian König wrote: Based on an idea from Dave, but cleaned up a bit. We had multiple fields for essentially the same thing. Now bo->size is the original size of the BO in arbitrary units, usually bytes. bo->mem.nu

Re: [PATCH] drm/ttm: cleanup BO size handling

2020-12-07 Thread Daniel Vetter
On Mon, Dec 7, 2020 at 5:33 PM Christian König wrote: > > Based on an idea from Dave, but cleaned up a bit. > > We had multiple fields for essentially the same thing. > > Now bo->size is the original size of the BO in arbitrary > units, usually bytes. > > bo->mem.num_pages is the size in number of

[PATCH] drm/ttm: cleanup BO size handling

2020-12-07 Thread Christian König
Based on an idea from Dave, but cleaned up a bit. We had multiple fields for essentially the same thing. Now bo->size is the original size of the BO in arbitrary units, usually bytes. bo->mem.num_pages is the size in number of pages in the resource domain of bo->mem.mem_type. Signed-off-by: Chr