Re: [PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

2020-07-29 Thread Christian König
Am 29.07.20 um 02:08 schrieb Dave Airlie: [SNIP] Landed this in drm-next as well. By the way there is another design bug in TTM which only affects Nouveau. See ttm_mem_io_reserve_vm() and ttm_mem_io_free_vm(). What happens is that as soon as you have an userspace VM mapping the BO ends up

Re: [PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

2020-07-28 Thread Dave Airlie
On Tue, 28 Jul 2020 at 17:49, Christian König wrote: > > Am 28.07.20 um 06:17 schrieb Dave Airlie: > > From: Dave Airlie > > > > This is confusing, and from my reading of all the drivers only > > nouveau got this right. > > > > Just make the API act under driver control of it's own allocation > >

Re: [PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

2020-07-28 Thread Christian König
Am 28.07.20 um 06:17 schrieb Dave Airlie: From: Dave Airlie This is confusing, and from my reading of all the drivers only nouveau got this right. Just make the API act under driver control of it's own allocation failing, and don't call destroy, if the page table fails to create there is nothi

[PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

2020-07-27 Thread Dave Airlie
From: Dave Airlie This is confusing, and from my reading of all the drivers only nouveau got this right. Just make the API act under driver control of it's own allocation failing, and don't call destroy, if the page table fails to create there is nothing to cleanup here. (I'm willing to believe