Re: [PATCH] drm/tinydrm: Move backlight helpers to a separate file

2017-09-25 Thread Daniel Vetter
On Fri, Sep 22, 2017 at 04:27:28PM +0530, Meghana Madhyastha wrote: > Move backlight helpers from tinydrm-helpers.c to > tinydrm-backlight.c > > Signed-off-by: Meghana Madhyastha Might be good if we discuss this a bit on irc first. Just moving the code around verbatim isn't all that useful, the

Re: [Outreachy kernel] [PATCH] drm/tinydrm: Move backlight helpers to a separate file

2017-09-22 Thread Greg KH
On Fri, Sep 22, 2017 at 04:27:28PM +0530, Meghana Madhyastha wrote: > Move backlight helpers from tinydrm-helpers.c to > tinydrm-backlight.c That says _what_ you did, but not _why_ you are doing it, which really is the more important part. thanks, greg k-h ___

[PATCH] drm/tinydrm: Move backlight helpers to a separate file

2017-09-22 Thread Meghana Madhyastha
Move backlight helpers from tinydrm-helpers.c to tinydrm-backlight.c Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/tinydrm/core/Makefile| 2 +- drivers/gpu/drm/tinydrm/core/tinydrm-backlight.c | 103 +++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c |