Re: [PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-18 Thread Luca Ceresoli
Hello Tomi, On Fri, 18 Jul 2025 14:13:03 +0300 Tomi Valkeinen wrote: > Hi, > > On 17/07/2025 16:56, Luca Ceresoli wrote: > > Hello Jyri, Tomi, Michael, > > > > On Thu, 17 Jul 2025 09:49:44 +0200 > > "Michael Walle" wrote: > > > >> Hi, > >> > >> thanks for taking a look! > >> > >>> Howeve

Re: [PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-18 Thread Tomi Valkeinen
Hi, On 17/07/2025 16:56, Luca Ceresoli wrote: > Hello Jyri, Tomi, Michael, > > On Thu, 17 Jul 2025 09:49:44 +0200 > "Michael Walle" wrote: > >> Hi, >> >> thanks for taking a look! >> >>> However allocating an encoder using a bridge alloc function (while we >>> used to call an encoder allocation

Re: [PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-17 Thread Luca Ceresoli
Hello Jyri, Tomi, Michael, On Thu, 17 Jul 2025 09:49:44 +0200 "Michael Walle" wrote: > Hi, > > thanks for taking a look! > > > However allocating an encoder using a bridge alloc function (while we > > used to call an encoder allocation function) looks counter-intuitive. > > > > We had discusse

Re: [PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-17 Thread Michael Walle
Hi, thanks for taking a look! > However allocating an encoder using a bridge alloc function (while we > used to call an encoder allocation function) looks counter-intuitive. > > We had discussed on IRC a different idea, adding a wrapper structure > around the bridge. Quoting your proposal: > >

Re: [PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-17 Thread Luca Ceresoli
Hello Michael, On Wed, 16 Jul 2025 15:41:07 +0200 Michael Walle wrote: > Convert the tidss encoder to use devm_drm_bridge_alloc(). Instead of > allocating the memory by drmm_simple_encoder_alloc() use > devm_drm_bridge_alloc() and initialize the encoder afterwards. > > Fixes: a7748dd127ea ("drm

[PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-16 Thread Michael Walle
Convert the tidss encoder to use devm_drm_bridge_alloc(). Instead of allocating the memory by drmm_simple_encoder_alloc() use devm_drm_bridge_alloc() and initialize the encoder afterwards. Fixes: a7748dd127ea ("drm/bridge: get/put the bridge reference in drm_bridge_add/remove()") Signed-off-by: M