Re: [PATCH] drm/tegra: sor: Remove redundant error logging

2023-01-20 Thread Deepak R Varma
On Tue, Dec 20, 2022 at 02:27:50AM +0530, Deepak R Varma wrote: > On Mon, Dec 12, 2022 at 10:44:55AM +0530, Deepak R Varma wrote: > > Hello, > May I please request a review and feedback on this patch proposal? > > Also, I was able to build the changes for ARM arch verified using modinfo > tegr-dr

Re: [PATCH] drm/tegra: sor: Remove redundant error logging

2022-12-19 Thread Deepak R Varma
On Mon, Dec 12, 2022 at 10:44:55AM +0530, Deepak R Varma wrote: Hello, May I please request a review and feedback on this patch proposal? Also, I was able to build the changes for ARM arch verified using modinfo tegr-drm.ko command. Thank you, ./drv > A call to platform_get_irq() already prin

[PATCH] drm/tegra: sor: Remove redundant error logging

2022-12-11 Thread Deepak R Varma
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well. Issue identified