Re: [PATCH] drm/sun4i: backend: Fix error pointers in sun4i_backend_atomic_check

2025-08-07 Thread Dan Carpenter
On Fri, Mar 14, 2025 at 11:00:26AM -0500, Chenyuan Yang wrote: > HI Maxime. > > Thanks so much for pointing that out! > > How about such a patch? > This patch is corrupted so we can't review it. > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c > b/drivers/gpu/drm/sun4i/sun4i_backend.c > in

[PATCH] drm/sun4i: backend: Fix error pointers in sun4i_backend_atomic_check

2025-03-15 Thread Chenyuan Yang
The function sun4i_backend_atomic_check was dereferencing pointers returned by drm_atomic_get_plane_state without checking for errors. This could lead to undefined behavior if the function returns an error pointer. This commit adds checks using IS_ERR to ensure that plane_state is valid before der

Re: [PATCH] drm/sun4i: backend: Fix error pointers in sun4i_backend_atomic_check

2025-03-15 Thread Chenyuan Yang
HI Maxime. Thanks so much for pointing that out! How about such a patch? diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c index 2dded3b828df..5ad0e90d3e6b 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -

Re: [PATCH] drm/sun4i: backend: Fix error pointers in sun4i_backend_atomic_check

2025-03-14 Thread Maxime Ripard
Hi, On Thu, Mar 13, 2025 at 08:20:29PM -0500, Chenyuan Yang wrote: > The function sun4i_backend_atomic_check was dereferencing pointers > returned by drm_atomic_get_plane_state without checking for errors. This > could lead to undefined behavior if the function returns an error pointer. > > This