Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h

2021-09-01 Thread Maxime Ripard
On Wed, Sep 01, 2021 at 11:13:01AM +0800, Chen-Yu Tsai wrote: > On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec > wrote: > > > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > > recommendation of having arguments enclosed in parenthesis. While that > > didn't change anything for

Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h

2021-08-31 Thread Chen-Yu Tsai
On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec wrote: > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > recommendation of having arguments enclosed in parenthesis. While that > didn't change anything for quiet sometime, it actually become important

[PATCH] drm/sun4i: Fix macros in sun8i_csc.h

2021-08-31 Thread Jernej Skrabec
Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual recommendation of having arguments enclosed in parenthesis. While that didn't change anything for quiet sometime, it actually become important after CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC m