Re: [PATCH] drm/stm: Fix bus_flags handling

2020-10-20 Thread Marek Vasut
On 10/16/20 7:44 PM, Sam Ravnborg wrote: > Hi Marek. Hi, > On Sat, Oct 03, 2020 at 01:07:26AM +0200, Marek Vasut wrote: >> The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW >> or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. > > So after reading this paragrahp

Re: [PATCH] drm/stm: Fix bus_flags handling

2020-10-16 Thread Sam Ravnborg
Hi Marek. On Sat, Oct 03, 2020 at 01:07:26AM +0200, Marek Vasut wrote: > The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW > or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. So after reading this paragrahp I assumed this patch would fix this, alas there is no c

[PATCH] drm/stm: Fix bus_flags handling

2020-10-03 Thread Marek Vasut
The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge or display might require, these flags are never set, and thus the LTDC GCR_DEPOL and GCR_PCPOL bits are never set