Re: [PATCH] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-09-05 Thread Javier Martinez Canillas
On 9/5/22 13:34, Thomas Zimmermann wrote: [...] >>> >> >> Yes, I was abusing the concept of encoder here just to have a place where >> I could hook the enable / disable logic, since I was looking at the other >> DRM objects helper operations structures and found that these were only >> defined fo

Re: [PATCH] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-09-05 Thread Thomas Zimmermann
Hi Am 05.09.22 um 13:00 schrieb Javier Martinez Canillas: Hello Thomas, Thanks for your feedback and comments. On 9/5/22 12:41, Thomas Zimmermann wrote: Hi Javier Am 28.08.22 um 17:11 schrieb Javier Martinez Canillas: The simple display pipeline is a set of helpers that can be used by DRM d

Re: [PATCH] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-09-05 Thread Javier Martinez Canillas
On 9/5/22 13:00, Javier Martinez Canillas wrote: >>> +static void ssd130x_encoder_helper_atomic_enable(struct drm_encoder >>> *encoder, >>> +struct drm_atomic_state *state) >>> +{ >>> + struct drm_device *drm = encoder->dev; >>> + struct ssd130x_devi

Re: [PATCH] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-09-05 Thread Javier Martinez Canillas
Hello Thomas, Thanks for your feedback and comments. On 9/5/22 12:41, Thomas Zimmermann wrote: > Hi Javier > > Am 28.08.22 um 17:11 schrieb Javier Martinez Canillas: >> The simple display pipeline is a set of helpers that can be used by DRM >> drivers to avoid dealing with all the needed compone

Re: [PATCH] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-09-05 Thread Thomas Zimmermann
Hi Javier Am 28.08.22 um 17:11 schrieb Javier Martinez Canillas: The simple display pipeline is a set of helpers that can be used by DRM drivers to avoid dealing with all the needed components and just define a few functions to operate a simple display device with one full-screen scanout buffer

[PATCH] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-08-28 Thread Javier Martinez Canillas
The simple display pipeline is a set of helpers that can be used by DRM drivers to avoid dealing with all the needed components and just define a few functions to operate a simple display device with one full-screen scanout buffer feeding a single output. But it is arguable that this provides the