Re: [PATCH] drm/sprd: remove redundant error logging

2022-12-22 Thread Chunyan Zhang
On Sun, 11 Dec 2022 at 21:55, Deepak R Varma wrote: > > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its return > value in the caller is redundant and should be removed. The clean up > also makes if condition bl

Re: [PATCH] drm/sprd: remove redundant error logging

2022-12-20 Thread Thomas Zimmermann
Hi Am 19.12.22 um 21:55 schrieb Deepak R Varma: On Sun, Dec 11, 2022 at 07:25:08PM +0530, Deepak R Varma wrote: Hello, May I please request a review and feedback on this patch proposal? Added to drm-misc-next. Thanks for the patch. Best regards Thomas Thank you, ./drv A call to platform

Re: [PATCH] drm/sprd: remove redundant error logging

2022-12-19 Thread Deepak R Varma
On Sun, Dec 11, 2022 at 07:25:08PM +0530, Deepak R Varma wrote: Hello, May I please request a review and feedback on this patch proposal? Thank you, ./drv > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its ret

[PATCH] drm/sprd: remove redundant error logging

2022-12-11 Thread Deepak R Varma
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well. Issue identified