RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-31 Thread Liu, Monk
; Liu, Monk ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) On Fri, Aug 27, 2021 at 08:30:32PM +0200, Christian König wrote: > Yeah, that's what I meant with that the start of processing a job is a > bit swa

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-31 Thread Daniel Vetter
t; > > scheduled to the ring doesn't represent it's being processed > > > > > by hw. > > > > > > > > > > Thanks > > > > > > > > > > -- > > > >

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Christian König
amd-...@lists.freedesktop.org; Koenig, Christian Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) Attached quick patch for per job TTL calculation to make more precises next timer expiration. It's on top of the patch in this thre

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
ovsky, Andrey Sent: Friday, August 27, 2021 4:14 AM To: Liu, Monk ; amd-...@lists.freedesktop.org; Koenig, Christian Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) Attached quick patch for per job TTL calculation to make more prec

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
- Monk Liu | Cloud-GPU Core team -- -Original Message- From: Grodzovsky, Andrey Sent: Friday, August 27, 2021 4:14 AM To: Liu, Monk ; amd-...@lists.freedesktop.org; Koenig, Christian Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sc

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Christian König
freedesktop.org; Koenig, Christian Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) Attached quick patch for per job TTL calculation to make more precises next timer expiration. It's on top of the patch in this thread. Let me know i

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Christian König
27, 2021 2:12 PM To: Grodzovsky, Andrey ; Liu, Monk ; amd-...@lists.freedesktop.org; Koenig, Christian Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) I don't think that this will be necessary nor desired. See the job should

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) I don't think that this will be necessary nor desired. See the job should be cleaned up as soon as possible after it is finished or otherwise we won't cancel the timeout quick enough either. C

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
eedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) Attached quick patch for per job TTL calculation to make more precises next timer expiration. It's on top of the patch in this thread. Let me know if this makes sense. Andrey On 2021-08-26 10:03 a.m., Andrey

RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Liu, Monk
From: Christian König Sent: Thursday, August 26, 2021 8:38 PM To: Liu, Monk ; amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) Am 26.08.21 um 13:55 schrieb Liu, Monk: > [AMD Official Use Only] > &

RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Liu, Monk
riginal Message- From: Christian König Sent: Friday, August 27, 2021 2:12 PM To: Grodzovsky, Andrey ; Liu, Monk ; amd-...@lists.freedesktop.org; Koenig, Christian Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) I don't thi

RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Liu, Monk
Cloud-GPU Core team -- -Original Message- From: Grodzovsky, Andrey Sent: Friday, August 27, 2021 4:14 AM To: Liu, Monk ; amd-...@lists.freedesktop.org; Koenig, Christian Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of tim

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-26 Thread Christian König
I don't think that this will be necessary nor desired. See the job should be cleaned up as soon as possible after it is finished or otherwise we won't cancel the timeout quick enough either. Christian. Am 26.08.21 um 22:14 schrieb Andrey Grodzovsky: Attached quick patch for per job TTL calcul

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-26 Thread Andrey Grodzovsky
Attached quick patch for per job TTL calculation to make more precises next timer expiration. It's on top of the patch in this thread. Let me know if this makes sense. Andrey On 2021-08-26 10:03 a.m., Andrey Grodzovsky wrote: On 2021-08-26 12:55 a.m., Monk Liu wrote: issue: in cleanup_job t

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-26 Thread Andrey Grodzovsky
On 2021-08-26 12:55 a.m., Monk Liu wrote: issue: in cleanup_job the cancle_delayed_work will cancel a TO timer even the its corresponding job is still running. fix: do not cancel the timer in cleanup_job, instead do the cancelling only when the heading job is signaled, and if there is a "next"

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-26 Thread Daniel Vetter
Monk Liu | Cloud-GPU Core team > > -- > > > > -Original Message----- > > From: Christian König > > Sent: Thursday, August 26, 2021 6:09 PM > > To: Liu, Monk ; amd-...@lists.freedesktop.org > > Cc: dri-devel@li

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-26 Thread Christian König
eedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) Am 26.08.21 um 06:55 schrieb Monk Liu: issue: in cleanup_job the cancle_delayed_work will cancel a TO timer even the its corresponding job is still running. Yeah, that makes a lot more sense. fix: do not cancel

RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-26 Thread Liu, Monk
-- -Original Message- From: Christian König Sent: Thursday, August 26, 2021 6:09 PM To: Liu, Monk ; amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v3) Am 26.08.21 um 06:5

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-26 Thread Christian König
Am 26.08.21 um 06:55 schrieb Monk Liu: issue: in cleanup_job the cancle_delayed_work will cancel a TO timer even the its corresponding job is still running. Yeah, that makes a lot more sense. fix: do not cancel the timer in cleanup_job, instead do the cancelling only when the heading job is

[PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-25 Thread Monk Liu
issue: in cleanup_job the cancle_delayed_work will cancel a TO timer even the its corresponding job is still running. fix: do not cancel the timer in cleanup_job, instead do the cancelling only when the heading job is signaled, and if there is a "next" job we start_timeout again. v2: further clea