Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Maíra Canal
Hi Philipp, On 23/01/25 09:13, Philipp Stanner wrote: On Thu, 2025-01-23 at 08:10 -0300, Maíra Canal wrote: Hi Philipp, On 23/01/25 05:10, Philipp Stanner wrote: On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: Hi Philipp, On 22/01/25 11:08, Philipp Stanner wrote: drm_sched_init() has

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 08:10 -0300, Maíra Canal wrote: > Hi Philipp, > > On 23/01/25 05:10, Philipp Stanner wrote: > > On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > > > Hi Philipp, > > > > > > On 22/01/25 11:08, Philipp Stanner wrote: > > > > drm_sched_init() has a great many parameters

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Maíra Canal
Hi Philipp, On 23/01/25 05:10, Philipp Stanner wrote: On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: Hi Philipp, On 22/01/25 11:08, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the g

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Tvrtko Ursulin
On 23/01/2025 09:35, Philipp Stanner wrote: On Thu, 2025-01-23 at 10:29 +0100, Danilo Krummrich wrote: On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote:  int

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Danilo Krummrich
On Thu, Jan 23, 2025 at 10:35:43AM +0100, Philipp Stanner wrote: > On Thu, 2025-01-23 at 10:29 +0100, Danilo Krummrich wrote: > > On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: > > > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > > > On Wed, 22 Jan 2025 15:08:20 +01

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 10:29 +0100, Danilo Krummrich wrote: > On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: > > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > > On Wed, 22 Jan 2025 15:08:20 +0100 > > > Philipp Stanner wrote: > > > > > > >  int drm_sched_init(struc

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Danilo Krummrich
On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > > >  int drm_sched_init(struct drm_gpu_scheduler *sched, > > > -    const struct drm_sched_backend_o

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 09:10 +0100, Philipp Stanner wrote: > On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > > Hi Philipp, > > > > On 22/01/25 11:08, Philipp Stanner wrote: > > > drm_sched_init() has a great many parameters and upcoming new > > > functionality for the scheduler might add ev

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Boris Brezillon
On Thu, 23 Jan 2025 08:33:01 +0100 Philipp Stanner wrote: > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > > >  int drm_sched_init(struct drm_gpu_scheduler *sched, > > > -    const struct drm_sched_backend_ops

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > Hi Philipp, > > On 22/01/25 11:08, Philipp Stanner wrote: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great number of parameters reduces readabi

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
On Wed, 2025-01-22 at 20:37 -0800, Matthew Brost wrote: > On Wed, Jan 22, 2025 at 06:04:58PM +0100, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 16:14:59 + > > Tvrtko Ursulin wrote: > > > > > On 22/01/2025 15:51, Boris Brezillon wrote: > > > > On Wed, 22 Jan 2025 15:08:20 +0100 > > > > Phil

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > On Wed, 22 Jan 2025 15:08:20 +0100 > Philipp Stanner wrote: > > >  int drm_sched_init(struct drm_gpu_scheduler *sched, > > -    const struct drm_sched_backend_ops *ops, > > -    struct workqueue_struct *submit_wq, > > -    u32 num_rqs, u

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Matthew Brost
On Wed, Jan 22, 2025 at 06:04:58PM +0100, Boris Brezillon wrote: > On Wed, 22 Jan 2025 16:14:59 + > Tvrtko Ursulin wrote: > > > On 22/01/2025 15:51, Boris Brezillon wrote: > > > On Wed, 22 Jan 2025 15:08:20 +0100 > > > Philipp Stanner wrote: > > > > > >> --- a/drivers/gpu/drm/panthor/pant

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Maíra Canal
Hi Philipp, On 22/01/25 11:08, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: > int drm_sched_init(struct drm_gpu_scheduler *sched, > -const struct drm_sched_backend_ops *ops, > -struct workqueue_struct *submit_wq, > -u32 num_rqs, u32 credit_limit, unsigned int hang_l

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 16:14:59 + Tvrtko Ursulin wrote: > On 22/01/2025 15:51, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > >> --- a/drivers/gpu/drm/panthor/panthor_sched.c > >> +++ b/drivers/gpu/drm/panthor/panthor_sched.c > >> @@ -3272,6 +3

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Tvrtko Ursulin
On 22/01/2025 15:51, Boris Brezillon wrote: On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -3272,6 +3272,7 @@ group_create_queue(struct panthor_group *group, const str

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -3272,6 +3272,7 @@ group_create_queue(struct panthor_group *group, > const struct drm_panthor_queue_create *args) > { >

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Christian König
Am 22.01.25 um 16:23 schrieb Philipp Stanner: On Wed, 2025-01-22 at 16:06 +0100, Christian König wrote: Am 22.01.25 um 15:48 schrieb Philipp Stanner: On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: Am 22.01.25 um 15:08 schrieb Philipp Stanner: drm_sched_init() has a great many param

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Matthew Brost
On Wed, Jan 22, 2025 at 04:06:10PM +0100, Christian König wrote: > Am 22.01.25 um 15:48 schrieb Philipp Stanner: > > On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > > > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > > > drm_sched_init() has a great many parameters and upcoming new >

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
On Wed, 2025-01-22 at 16:06 +0100, Christian König wrote: > Am 22.01.25 um 15:48 schrieb Philipp Stanner: > > On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > > > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > > > drm_sched_init() has a great many parameters and upcoming new > > > > f

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Christian König
Am 22.01.25 um 15:48 schrieb Philipp Stanner: On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: Am 22.01.25 um 15:08 schrieb Philipp Stanner: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Matthew Brost
On Wed, Jan 22, 2025 at 03:48:54PM +0100, Philipp Stanner wrote: > On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > > drm_sched_init() has a great many parameters and upcoming new > > > functionality for the scheduler might add even mor

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great number of parameters reduces readability and

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Christian König
Am 22.01.25 um 15:08 schrieb Philipp Stanner: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("drm/nouve

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Danilo Krummrich
On Wed, Jan 22, 2025 at 03:08:20PM +0100, Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming in: > > co

[PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_sched_init