[PATCH] drm/sched: Split drm_sched_job_init

2021-08-17 Thread Daniel Vetter
This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is that I want to push the dependency tracking helpe

Re: [PATCH] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Daniel Vetter
On Thu, Jun 24, 2021 at 11:00 PM Emma Anholt wrote: > > On Thu, Jun 24, 2021 at 1:45 PM Daniel Vetter wrote: > > > > This is a very confusingly named function, because not just does it > > init an object, it arms it and provides a point of no return for > > pushing a job into the scheduler. It wo

Re: [PATCH] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Emma Anholt
On Thu, Jun 24, 2021 at 1:45 PM Daniel Vetter wrote: > > This is a very confusingly named function, because not just does it > init an object, it arms it and provides a point of no return for > pushing a job into the scheduler. It would be nice if that's a bit > clearer in the interface. > > But t

[PATCH] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Daniel Vetter
This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is that I want to push the dependency tracking helpe