Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-29 Thread Matthew Brost
On Mon, Jan 29, 2024 at 12:10:52PM -0500, Luben Tuikov wrote: > On 2024-01-29 02:44, Christian König wrote: > > Am 26.01.24 um 17:29 schrieb Matthew Brost: > >> On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: > >>> Am 25.01.24 um 18:30 schrieb Matthew Brost: > On Thu, Jan 25,

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-29 Thread Luben Tuikov
On 2024-01-29 02:44, Christian König wrote: > Am 26.01.24 um 17:29 schrieb Matthew Brost: >> On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: >>> Am 25.01.24 um 18:30 schrieb Matthew Brost: On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: > Am 24.01.24 um 22

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Vlastimil Babka
On 1/29/24 08:44, Christian König wrote: > Am 26.01.24 um 17:29 schrieb Matthew Brost: >> On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: >>> Am 25.01.24 um 18:30 schrieb Matthew Brost: On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: > Am 24.01.24 um 22:08

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Christian König
Am 26.01.24 um 17:29 schrieb Matthew Brost: On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: Am 25.01.24 um 18:30 schrieb Matthew Brost: On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: Am 24.01.24 um 22:08 schrieb Matthew Brost: All entities must be drained in

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Luben Tuikov
On 2024-01-26 11:29, Matthew Brost wrote: > On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: >> Am 25.01.24 um 18:30 schrieb Matthew Brost: >>> On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: Am 24.01.24 um 22:08 schrieb Matthew Brost: > All entities m

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Luben Tuikov
On 2024-01-24 16:08, Matthew Brost wrote: > All entities must be drained in the DRM scheduler run job worker to > avoid the following case. An entity found that is ready, no job found > ready on entity, and run job worker goes idle with other entities + jobs > ready. Draining all ready entities (i.

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-26 Thread Matthew Brost
On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: > Am 25.01.24 um 18:30 schrieb Matthew Brost: > > On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: > > > > > > Am 24.01.24 um 22:08 schrieb Matthew Brost: > > > > All entities must be drained in the DRM scheduler run

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-26 Thread Christian König
Am 25.01.24 um 18:30 schrieb Matthew Brost: On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: Am 24.01.24 um 22:08 schrieb Matthew Brost: All entities must be drained in the DRM scheduler run job worker to avoid the following case. An entity found that is ready, no job found rea

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-25 Thread Dave Airlie
Just FYI I'm pulling this into drm-fixes straight as is, since if fixes the regression and avoids the revert, however please keep discussing until we are sure things are right, and we can deal with any fixes in a follow-up patch. Dave. On Fri, 26 Jan 2024 at 03:32, Matthew Brost wrote: > > On T

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-25 Thread Matthew Brost
On Thu, Jan 25, 2024 at 10:24:24AM +0100, Vlastimil Babka wrote: > On 1/24/24 22:08, Matthew Brost wrote: > > All entities must be drained in the DRM scheduler run job worker to > > avoid the following case. An entity found that is ready, no job found > > ready on entity, and run job worker goes id

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-25 Thread Matthew Brost
On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: > > > Am 24.01.24 um 22:08 schrieb Matthew Brost: > > All entities must be drained in the DRM scheduler run job worker to > > avoid the following case. An entity found that is ready, no job found > > ready on entity, and run job wor

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-25 Thread Christian König
Am 24.01.24 um 22:08 schrieb Matthew Brost: All entities must be drained in the DRM scheduler run job worker to avoid the following case. An entity found that is ready, no job found ready on entity, and run job worker goes idle with other entities + jobs ready. Draining all ready entities (i.e

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-25 Thread Vlastimil Babka
On 1/24/24 22:08, Matthew Brost wrote: > All entities must be drained in the DRM scheduler run job worker to > avoid the following case. An entity found that is ready, no job found > ready on entity, and run job worker goes idle with other entities + jobs > ready. Draining all ready entities (i.e.

[PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-24 Thread Matthew Brost
All entities must be drained in the DRM scheduler run job worker to avoid the following case. An entity found that is ready, no job found ready on entity, and run job worker goes idle with other entities + jobs ready. Draining all ready entities (i.e. loop over all ready entities) in the run job wo