Re: [PATCH] drm/sched: Document purpose of drm_sched_{start,stop}

2024-10-31 Thread Philipp Stanner
On Tue, 2024-10-29 at 09:47 -0400, Alex Deucher wrote: > On Tue, Oct 29, 2024 at 9:39 AM Philipp Stanner > wrote: > > > > drm_sched_start()'s and drm_sched_stop()'s names suggest that those > > functions might be intended for actively starting and stopping the > > scheduler on initialization and

Re: [PATCH] drm/sched: Document purpose of drm_sched_{start,stop}

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 9:39 AM Philipp Stanner wrote: > > drm_sched_start()'s and drm_sched_stop()'s names suggest that those > functions might be intended for actively starting and stopping the > scheduler on initialization and teardown. > > They are, however, only used on timeout handling (rese

[PATCH] drm/sched: Document purpose of drm_sched_{start,stop}

2024-10-29 Thread Philipp Stanner
drm_sched_start()'s and drm_sched_stop()'s names suggest that those functions might be intended for actively starting and stopping the scheduler on initialization and teardown. They are, however, only used on timeout handling (reset recovery). The docstrings should reflect that to prevent confusio