Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-07-04 Thread Heiko Stuebner
On Fri, 17 Jun 2022 17:26:52 -0700, Brian Norris wrote: > It's possible for users to try to duplicate the CRTC state even when the > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > users of __drm_atomic_helper_crtc_duplicate_state()) already guard this > with a WARN_ON()

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-24 Thread Heiko Stuebner
Am Freitag, 24. Juni 2022, 19:57:53 CEST schrieb Brian Norris: > On Fri, Jun 24, 2022 at 12:23 AM Heiko Stuebner wrote: > > The interesting question would be, do we want some fixes tag for it? > > I'm not aware of any currently-upstream code that will hit this [1]. > I've hit it in out-of-tree co

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-24 Thread Brian Norris
On Fri, Jun 24, 2022 at 12:23 AM Heiko Stuebner wrote: > The interesting question would be, do we want some fixes tag for it? I'm not aware of any currently-upstream code that will hit this [1]. I've hit it in out-of-tree code (or, code that I submitted to dri-devel, but wasn't accepted as-is), a

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-24 Thread Heiko Stuebner
Am Freitag, 24. Juni 2022, 01:44:52 CEST schrieb Doug Anderson: > Hi, > > On Fri, Jun 17, 2022 at 5:27 PM Brian Norris wrote: > > > > It's possible for users to try to duplicate the CRTC state even when the > > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > > users of

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-23 Thread Doug Anderson
Hi, On Fri, Jun 17, 2022 at 5:27 PM Brian Norris wrote: > > It's possible for users to try to duplicate the CRTC state even when the > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > users of __drm_atomic_helper_crtc_duplicate_state()) already guard this > with a WARN_O

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-23 Thread Sean Paul
On Fri, Jun 17, 2022 at 05:26:52PM -0700, Brian Norris wrote: > It's possible for users to try to duplicate the CRTC state even when the > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > users of __drm_atomic_helper_crtc_duplicate_state()) already guard this > with a WARN

[PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-17 Thread Brian Norris
It's possible for users to try to duplicate the CRTC state even when the state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other users of __drm_atomic_helper_crtc_duplicate_state()) already guard this with a WARN_ON() instead of crashing, so let's do that here too. Signed-off-by: