Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-10 Thread Diederik de Haas
Hi Heiko, On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote: > From: Heiko Stuebner > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number > of lines too, so convert the error prints for the dsi-driver. > > Signed-off-by: Heiko Stuebner > --- > .../gpu/drm/rockchip/d

Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-09 Thread Dragan Simic
Hello Heiko, Thanks for the patch. Please, see a couple of comments below. On 2024-11-08 15:44, Heiko Stuebner wrote: From: Heiko Stuebner DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number of lines too, so convert the error prints for the dsi-driver. Signed-off-by:

Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Diederik de Haas
On Fri Nov 8, 2024 at 5:31 PM CET, Heiko Stübner wrote: > Am Freitag, 8. November 2024, 16:21:24 CET schrieb Diederik de Haas: > > On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote: > > > From: Heiko Stuebner > > > > > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a numbe

Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Heiko Stübner
Am Freitag, 8. November 2024, 16:21:24 CET schrieb Diederik de Haas: > On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number > > of lines too, so convert the error prints for the dsi-driver

Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Diederik de Haas
On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote: > From: Heiko Stuebner > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number > of lines too, so convert the error prints for the dsi-driver. > > Signed-off-by: Heiko Stuebner Should this have a Fixes tag? Because in

[PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Heiko Stuebner
From: Heiko Stuebner DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number of lines too, so convert the error prints for the dsi-driver. Signed-off-by: Heiko Stuebner --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 80 ++- 1 file changed, 26 insertions(+)