Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-25 Thread Huang Jiachai
Hi Daniel, 在 2021/2/25 20:46, Daniel Stone 写道: Hi Sandy, On Thu, 25 Feb 2021 at 02:17, Huang Jiachai wrote: RK3399 and px30 can support YTR afbc format[RGB only], there is an hidden control bit to control this. Great, thanks for providing this information! Hi Alyssa, Can you a

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-25 Thread Daniel Stone
Hi Sandy, On Thu, 25 Feb 2021 at 02:17, Huang Jiachai wrote: > RK3399 and px30 can support YTR afbc format[RGB only], there is an > hidden control bit to control this. Great, thanks for providing this information! > Hi Alyssa, > > Can you add the following patch to test on your platfo

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-25 Thread Huang Jiachai
Hi Daniel,     RK3399 and px30 can support YTR afbc format[RGB only], there is an hidden control bit to control this. Hi Alyssa,     Can you add the following patch to test on your platform? thanks. diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-24 Thread Brian Starkey
On Wed, Feb 24, 2021 at 04:06:05PM +, Daniel Stone wrote: > Android punted on that from the beginning and just uses > XBGR for everything ... so it's not really a matter of dumb vs. smart > userspace, just equally dumb userspaces which disagree with each > other. ;) ...apart from HAL_PIXEL_FOR

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-24 Thread Daniel Stone
Hey, On Wed, 24 Feb 2021 at 14:58, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 7:50 PM Daniel Stone wrote: > > The issue is a userspace one though, not a kernel one. Userspace (e.g. > > GNOME Shell, Weston, Xorg) decides ahead of time that it's going to > > use XRGB, then use the modifier

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-24 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 7:50 PM Daniel Stone wrote: > > Hi Brian, > > On Tue, 23 Feb 2021 at 18:34, Brian Starkey wrote: > > On Tue, Feb 23, 2021 at 05:10:16PM +, Alyssa Rosenzweig wrote: > > > But it seems to me allowing > > > both BGR+YTR and RGB+YTR upstream is the better route than simply

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-24 Thread Daniel Stone
On Tue, 23 Feb 2021 at 21:49, Heiko Stuebner wrote: > On Tue, 11 Aug 2020 16:26:31 -0400, Alyssa Rosenzweig wrote: > > The AFBC decoder used in the Rockchip VOP assumes the use of the > > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > > buffers, which covers the RGBA8 and RGB56

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Heiko Stuebner
On Tue, 11 Aug 2020 16:26:31 -0400, Alyssa Rosenzweig wrote: > The AFBC decoder used in the Rockchip VOP assumes the use of the > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > buffers, which covers the RGBA8 and RGB565 formats supported in > vop_convert_afbc_format. Use of YTR

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
Hi Brian, On Tue, 23 Feb 2021 at 18:34, Brian Starkey wrote: > On Tue, Feb 23, 2021 at 05:10:16PM +, Alyssa Rosenzweig wrote: > > But it seems to me allowing > > both BGR+YTR and RGB+YTR upstream is the better route than simply > > preventing hardware from using AFBC at all, and there are nat

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
On Tue, Feb 23, 2021 at 05:10:16PM +, Alyssa Rosenzweig wrote: > > If YTR can't be turned off, then according to the AFBC spec - correct. > > There is no public AFBC spec, so I'm not sure how to respond to this. > > > If the hardware allows it to be configured to use YTR with other > > compon

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Alyssa Rosenzweig
> If YTR can't be turned off, then according to the AFBC spec - correct. There is no public AFBC spec, so I'm not sure how to respond to this. > If the hardware allows it to be configured to use YTR with other > component orders, I don't know exactly what the impact would be - > maybe nothing. I

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
On Tue, Feb 23, 2021 at 03:29:13PM +, Daniel Stone wrote: > On Tue, 23 Feb 2021 at 14:58, Brian Starkey wrote: > > On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > > > Mark, or others from Rockchip, can you please: > > > - explain if there is a way to enable/disable the YTR tran

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
On Tue, 23 Feb 2021 at 14:58, Brian Starkey wrote: > On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > > Mark, or others from Rockchip, can you please: > > - explain if there is a way to enable/disable the YTR transform in the > > VOP's AFBC decoder, similar to the split-block contro

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
Hi, On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > Mark, or others from Rockchip, can you please: > - explain if there is a way to enable/disable the YTR transform in the > VOP's AFBC decoder, similar to the split-block control bit? > - ack this patch which correctly declares that

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
Hi, On Tue, 23 Feb 2021 at 14:27, Daniel Stone wrote: > Bumping this one: it seems like the Rockchip VOP either always applies > the YTR transform, or has a YTR control bit which is not documented in > the driver's register definitions. This means that it is incorrect to > advertise the currently

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
Hi, On Wed, 12 Aug 2020 at 08:05, Alyssa Rosenzweig wrote: > The AFBC decoder used in the Rockchip VOP assumes the use of the > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > buffers, which covers the RGBA8 and RGB565 formats supported in > vop_convert_afbc_format. Use of YTR

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2020-08-12 Thread Daniel Vetter
On Wed, Aug 12, 2020 at 08:31:54AM +0200, Greg KH wrote: > On Tue, Aug 11, 2020 at 04:26:31PM -0400, Alyssa Rosenzweig wrote: > > The AFBC decoder used in the Rockchip VOP assumes the use of the > > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > > buffers, which covers the RGBA8

[PATCH] drm/rockchip: Require the YTR modifier for AFBC

2020-08-12 Thread Alyssa Rosenzweig
The AFBC decoder used in the Rockchip VOP assumes the use of the YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) buffers, which covers the RGBA8 and RGB565 formats supported in vop_convert_afbc_format. Use of YTR is signaled with the AFBC_FORMAT_MOD_YTR modifier, which prior to thi

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2020-08-11 Thread Greg KH
On Tue, Aug 11, 2020 at 04:26:31PM -0400, Alyssa Rosenzweig wrote: > The AFBC decoder used in the Rockchip VOP assumes the use of the > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > buffers, which covers the RGBA8 and RGB565 formats supported in > vop_convert_afbc_format. Use o