Re: [PATCH] drm/rect: remove useless call to clamp_t

2019-11-20 Thread Ville Syrjälä
On Wed, Nov 20, 2019 at 05:22:34PM +0200, Ville Syrjälä wrote: > On Tue, Nov 19, 2019 at 02:34:35PM +0100, Benjamin Gaignard wrote: > > Clamping a value between INT_MIN and INT_MAX always return the value itself > > and generate warnings when compiling with W=1. > > > > Signed-off-by: Benjamin Gai

Re: [PATCH] drm/rect: remove useless call to clamp_t

2019-11-20 Thread Ville Syrjälä
On Tue, Nov 19, 2019 at 02:34:35PM +0100, Benjamin Gaignard wrote: > Clamping a value between INT_MIN and INT_MAX always return the value itself > and generate warnings when compiling with W=1. > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_rect.c | 8 > 1 file changed

Re: [PATCH] drm/rect: remove useless call to clamp_t

2019-11-20 Thread Jani Nikula
On Tue, 19 Nov 2019, Benjamin Gaignard wrote: > Clamping a value between INT_MIN and INT_MAX always return the value itself > and generate warnings when compiling with W=1. Does that hold for 32-bit too? BR, Jani. > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_rect.c | 8 +++

[PATCH] drm/rect: remove useless call to clamp_t

2019-11-19 Thread Benjamin Gaignard
Clamping a value between INT_MIN and INT_MAX always return the value itself and generate warnings when compiling with W=1. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_rect.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_rect.c b/driv