2014/1/7 Alex Deucher :
> + if (radeon_hw_i2c == 1)
> + DRM_INFO("hw_i2c forced on, you may experience display
> detection problems!\n");
What about simple
if (radeon_hw_i2c)
? Values 2, 3, ... also enable i2c.
On 07.01.2014 16:14, Alex Deucher wrote:
> The hw i2c engines are disabled by default as the
> current implementation is still experimental. Print
> a warning when users enable it so that it's obvious
> when the option is enabled.
>
Does hardware I2C actually have any advantage in the DDC use cas
Am 07.01.2014 16:14, schrieb Alex Deucher:
> The hw i2c engines are disabled by default as the
> current implementation is still experimental. Print
> a warning when users enable it so that it's obvious
> when the option is enabled.
>
> Signed-off-by: Alex Deucher
> Cc: stable at vger.kernel.org
On Tue, Jan 7, 2014 at 11:16 AM, Rafa? Mi?ecki wrote:
> 2014/1/7 Alex Deucher :
>> + if (radeon_hw_i2c == 1)
>> + DRM_INFO("hw_i2c forced on, you may experience display
>> detection problems!\n");
>
> What about simple
> if (radeon_hw_i2c)
> ? Values 2, 3, ... also enable i2c.
The hw i2c engines are disabled by default as the
current implementation is still experimental. Print
a warning when users enable it so that it's obvious
when the option is enabled.
v2: check for non-0 rather than 1
Signed-off-by: Alex Deucher
Reviewed-by: Christian K?nig
Cc: stable at vger.ke
On Tue, Jan 7, 2014 at 10:58 AM, Grigori Goronzy wrote:
> On 07.01.2014 16:14, Alex Deucher wrote:
>>
>> The hw i2c engines are disabled by default as the
>> current implementation is still experimental. Print
>> a warning when users enable it so that it's obvious
>> when the option is enabled.
>
The hw i2c engines are disabled by default as the
current implementation is still experimental. Print
a warning when users enable it so that it's obvious
when the option is enabled.
Signed-off-by: Alex Deucher
Cc: stable at vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_i2c.c | 3 +++
1 file
