Re: [PATCH] drm/radeon: remove load callback

2024-06-21 Thread Christian König
Am 21.06.24 um 09:16 schrieb Thomas Zimmermann: Hi Am 20.06.24 um 16:30 schrieb Hoi Pok Wu: Dear Thomas, Thank you for testing my patch. The dev->dev_private is indeed the problem. However, most of the functions that uses dev->dev_private is passing drm_device as parameter, and then uses de

Re: [PATCH] drm/radeon: remove load callback

2024-06-21 Thread Thomas Zimmermann
Hi Am 20.06.24 um 16:30 schrieb Hoi Pok Wu: Dear Thomas, Thank you for testing my patch. The dev->dev_private is indeed the problem. However, most of the functions that uses dev->dev_private is passing drm_device as parameter, and then uses dev->dev_private to retrieve radeon_device, contradic

Re: [PATCH] drm/radeon: remove load callback

2024-06-20 Thread Hoi Pok Wu
Dear Thomas, Thank you for testing my patch. The dev->dev_private is indeed the problem. However, most of the functions that uses dev->dev_private is passing drm_device as parameter, and then uses dev->dev_private to retrieve radeon_device, contradicting what the patch intended. It should use rad

Re: [PATCH] drm/radeon: remove load callback

2024-06-19 Thread Thomas Zimmermann
Hi Am 07.06.24 um 03:14 schrieb wu hoi pok: this patch is to remove the load callback from the kms_driver, following closly to amdgpu, radeon_driver_load_kms and devm_drm_dev_alloc are used, most of the changes here are rdev->ddev to rdev_to_drm, which maps to adev_to_drm in amdgpu. however this

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Hoi Pok Wu
no problem, thanks for your time. wu On Fri, Jun 7, 2024 at 1:35 PM Christian König wrote: > > In general thanks for looking into this, but when you don't have > hardware to at least briefly validate your work we probably can't accept > that. > > I can see if I can get anybody looking into this,

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Christian König
In general thanks for looking into this, but when you don't have hardware to at least briefly validate your work we probably can't accept that. I can see if I can get anybody looking into this, but the odds that somebody has time and hardware are pretty low. Christian. Am 07.06.24 um 16:15

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Hoi Pok Wu
i do it because it is part of the todo list where the task is to remove load/unload callback there are only 2 drm_driver that still uses thats why i thought my amdgpu could test radeonsi but no, i still send it anyway regards, wu On Fri, Jun 7, 2024 at 3:51 AM Christian König wrote: > > Am 07.0

[PATCH] drm/radeon: remove load callback

2024-06-07 Thread wu hoi pok
this patch is to remove the load callback from the kms_driver, following closly to amdgpu, radeon_driver_load_kms and devm_drm_dev_alloc are used, most of the changes here are rdev->ddev to rdev_to_drm, which maps to adev_to_drm in amdgpu. however this patch is not tested on hardware, so if you are

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Christian König
Am 07.06.24 um 03:14 schrieb wu hoi pok: this patch is to remove the load callback from the kms_driver, following closly to amdgpu, radeon_driver_load_kms and devm_drm_dev_alloc are used, most of the changes here are rdev->ddev to rdev_to_drm, which maps to adev_to_drm in amdgpu. however this pat