[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Michel Dänzer
On Mon, 2013-04-22 at 12:15 -0400, Alex Deucher wrote: > On Mon, Apr 22, 2013 at 11:29 AM, Michel D?nzer wrote: > > On Mon, 2013-04-22 at 10:18 -0400, Alex Deucher wrote: > >> On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter > >> wrote: > >> > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeucher

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Dan Carpenter
On Mon, Apr 22, 2013 at 10:18:09AM -0400, Alex Deucher wrote: > On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter > wrote: > > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeucher at gmail.com wrote: > >> From: Alex Deucher > >> > >> Reported-by: Dan Carpenter > >> Signed-off-by: Alex Deucher >

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Michel Dänzer
On Mon, 2013-04-22 at 10:18 -0400, Alex Deucher wrote: > On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter > wrote: > > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeucher at gmail.com wrote: > >> From: Alex Deucher > >> > >> Reported-by: Dan Carpenter > >> Signed-off-by: Alex Deucher > >> ---

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Dan Carpenter
On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeucher at gmail.com wrote: > From: Alex Deucher > > Reported-by: Dan Carpenter > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/radeon/atombios.h|2 ++ > drivers/gpu/drm/radeon/radeon_atombios.c |6 ++ > 2 files changed, 4

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Alex Deucher
On Mon, Apr 22, 2013 at 11:29 AM, Michel D?nzer wrote: > On Mon, 2013-04-22 at 10:18 -0400, Alex Deucher wrote: >> On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter >> wrote: >> > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeucher at gmail.com wrote: >> >> From: Alex Deucher >> >> >> >> Reporte

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Alex Deucher
On Mon, Apr 22, 2013 at 10:31 AM, Dan Carpenter wrote: > On Mon, Apr 22, 2013 at 10:18:09AM -0400, Alex Deucher wrote: >> On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter >> wrote: >> > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeucher at gmail.com wrote: >> >> From: Alex Deucher >> >> >> >>

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Alex Deucher
On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter wrote: > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeucher at gmail.com wrote: >> From: Alex Deucher >> >> Reported-by: Dan Carpenter >> Signed-off-by: Alex Deucher >> --- >> drivers/gpu/drm/radeon/atombios.h|2 ++ >> drivers/gpu/

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread alexdeuc...@gmail.com
From: Alex Deucher Reported-by: Dan Carpenter Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/atombios.h|2 ++ drivers/gpu/drm/radeon/radeon_atombios.c |6 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/atombios.h b/drivers/

Re: [PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Michel Dänzer
On Mon, 2013-04-22 at 12:15 -0400, Alex Deucher wrote: > On Mon, Apr 22, 2013 at 11:29 AM, Michel Dänzer wrote: > > On Mon, 2013-04-22 at 10:18 -0400, Alex Deucher wrote: > >> On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter > >> wrote: > >> > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeuc...

Re: [PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Alex Deucher
ggest moving up the new > member, clarifying its name and/or adding a comment explaining what it > is for. > Looks good to me other than that. Sounds good. v3 attached. Alex From d21f9d7ef1645fcb1573c80a8b0160cd3208a22a Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Mon, 22 Apr 2013 0

Re: [PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Michel Dänzer
On Mon, 2013-04-22 at 10:18 -0400, Alex Deucher wrote: > On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter > wrote: > > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeuc...@gmail.com wrote: > >> From: Alex Deucher > >> > >> Reported-by: Dan Carpenter > >> Signed-off-by: Alex Deucher > >> --- >

Re: [PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Alex Deucher
On Mon, Apr 22, 2013 at 10:31 AM, Dan Carpenter wrote: > On Mon, Apr 22, 2013 at 10:18:09AM -0400, Alex Deucher wrote: >> On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter >> wrote: >> > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeuc...@gmail.com wrote: >> >> From: Alex Deucher >> >> >> >> Rep

Re: [PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Dan Carpenter
On Mon, Apr 22, 2013 at 10:18:09AM -0400, Alex Deucher wrote: > On Mon, Apr 22, 2013 at 10:08 AM, Dan Carpenter > wrote: > > On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeuc...@gmail.com wrote: > >> From: Alex Deucher > >> > >> Reported-by: Dan Carpenter > >> Signed-off-by: Alex Deucher > >>

Re: [PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Alex Deucher
.v5.ulClock.ulClockFreq = >> cpu_to_le32(clock); /* 10 khz */ >> + args.v3.ulClockFbDiv = cpu_to_le32((clock_type >> << 24) | clock); > > We've changed from v5 to v3. Was that intentional? Copy paste typo. fixed in v2 which is a

Re: [PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread Dan Carpenter
On Mon, Apr 22, 2013 at 10:03:13AM -0400, alexdeuc...@gmail.com wrote: > From: Alex Deucher > > Reported-by: Dan Carpenter > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/radeon/atombios.h|2 ++ > drivers/gpu/drm/radeon/radeon_atombios.c |6 ++ > 2 files changed, 4 in

[PATCH] drm/radeon: fix endian bugs in radeon_atom_get_clock_dividers()

2013-04-22 Thread alexdeucher
From: Alex Deucher Reported-by: Dan Carpenter Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/atombios.h|2 ++ drivers/gpu/drm/radeon/radeon_atombios.c |6 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/atombios.h b/drivers/