Re: [PATCH] drm/radeon: change function signature to pass full range

2018-09-18 Thread Mathieu Malaterre
On Fri, Apr 13, 2018 at 9:59 AM Huang Rui wrote: > On Thu, Apr 12, 2018 at 09:33:33PM +0200, Mathieu Malaterre wrote: > > In function ‘radeon_process_i2c_ch’ a comparison of a u8 value against > > 255 is done. Since it is always false, change the signature of this > > function to use an `int` ins

Re: [PATCH] drm/radeon: change function signature to pass full range

2018-09-17 Thread Alex Deucher
On Mon, Sep 17, 2018 at 4:29 PM Mathieu Malaterre wrote: > > > > On Fri, Apr 13, 2018 at 9:59 AM Huang Rui wrote: >> >> On Thu, Apr 12, 2018 at 09:33:33PM +0200, Mathieu Malaterre wrote: >> > In function ‘radeon_process_i2c_ch’ a comparison of a u8 value against >> > 255 is done. Since it is alwa

Re: [PATCH] drm/radeon: change function signature to pass full range

2018-04-13 Thread Huang Rui
On Thu, Apr 12, 2018 at 09:33:33PM +0200, Mathieu Malaterre wrote: > In function ‘radeon_process_i2c_ch’ a comparison of a u8 value against > 255 is done. Since it is always false, change the signature of this > function to use an `int` instead, which match the type used in caller: > `radeon_atom_h

[PATCH] drm/radeon: change function signature to pass full range

2018-04-13 Thread Mathieu Malaterre
In function ‘radeon_process_i2c_ch’ a comparison of a u8 value against 255 is done. Since it is always false, change the signature of this function to use an `int` instead, which match the type used in caller: `radeon_atom_hw_i2c_xfer`. Fix the following warning triggered with W=1: CC [M] driv