[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-18 Thread Michel Dänzer
On 15.08.2014 23:52, Christian K?nig wrote: > > I think I've figured out what the cause of the remaining issues is while > working on the implicit sync stuff. > > The issue happens when the flush is done because of a CS to the DMA ring > and a CS to the GFX ring directly after that which depends

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-18 Thread Christian König
Am 18.08.2014 um 11:10 schrieb Michel D?nzer: > On 15.08.2014 23:52, Christian K?nig wrote: >> I think I've figured out what the cause of the remaining issues is while >> working on the implicit sync stuff. >> >> The issue happens when the flush is done because of a CS to the DMA ring >> and a CS t

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-15 Thread Christian König
Hey guys, I think I've figured out what the cause of the remaining issues is while working on the implicit sync stuff. The issue happens when the flush is done because of a CS to the DMA ring and a CS to the GFX ring directly after that which depends on the DMA submission to be finished. In t

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-12 Thread Christian König
Am 11.08.2014 um 17:00 schrieb Alex Deucher: > On Mon, Aug 11, 2014 at 4:42 AM, Michel D?nzer wrote: >> On 08.08.2014 22:34, Alex Deucher wrote: >>> On Fri, Aug 8, 2014 at 9:31 AM, Alex Deucher >>> wrote: On Fri, Aug 8, 2014 at 4:50 AM, Michel D?nzer wrote: > On 08.08.2014 17:44,

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-11 Thread Michel Dänzer
On 08.08.2014 22:34, Alex Deucher wrote: > On Fri, Aug 8, 2014 at 9:31 AM, Alex Deucher wrote: >> On Fri, Aug 8, 2014 at 4:50 AM, Michel D?nzer wrote: >>> On 08.08.2014 17:44, Christian K?nig wrote: >>> On Thu, Aug 7, 2014 at 3:59 PM, Alex Deucher >>> wrote: We should be using P

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-11 Thread Alex Deucher
On Mon, Aug 11, 2014 at 4:42 AM, Michel D?nzer wrote: > On 08.08.2014 22:34, Alex Deucher wrote: >> On Fri, Aug 8, 2014 at 9:31 AM, Alex Deucher >> wrote: >>> On Fri, Aug 8, 2014 at 4:50 AM, Michel D?nzer wrote: On 08.08.2014 17:44, Christian K?nig wrote: On Thu, Aug 7, 2014 at 3:

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-08 Thread Michel Dänzer
On 08.08.2014 17:44, Christian K?nig wrote: On Thu, Aug 7, 2014 at 3:59 PM, Alex Deucher wrote: > We should be using PFP as much as possible. Does the attached > patch help? >> Unfortunately not. > > Maybe add a readback of the VM base addr pointer to make sure that the > write

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-08 Thread Michel Dänzer
On 08.08.2014 00:55, Alex Deucher wrote: > > Note that there is no PFP (or CE) on the compute queues so we can't > use PFP (or CE) for compute. AFAICT cik_hdp_flush_cp_ring_emit() always uses the PFP though. > Note also that the engine bit is not always consistent (for some packets 0 > = ME, 1

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-08 Thread Christian König
>>> On Thu, Aug 7, 2014 at 3:59 PM, Alex Deucher >>> wrote: We should be using PFP as much as possible. Does the attached patch help? > Unfortunately not. Maybe add a readback of the VM base addr pointer to make sure that the write has really reached the SBRM? Otherwise I'm out of ideas

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-08 Thread Alex Deucher
On Fri, Aug 8, 2014 at 9:31 AM, Alex Deucher wrote: > On Fri, Aug 8, 2014 at 4:50 AM, Michel D?nzer wrote: >> On 08.08.2014 17:44, Christian K?nig wrote: >> On Thu, Aug 7, 2014 at 3:59 PM, Alex Deucher >> wrote: >>> We should be using PFP as much as possible. Does the attached >

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-08 Thread Alex Deucher
On Fri, Aug 8, 2014 at 4:50 AM, Michel D?nzer wrote: > On 08.08.2014 17:44, Christian K?nig wrote: > On Thu, Aug 7, 2014 at 3:59 PM, Alex Deucher > wrote: >> We should be using PFP as much as possible. Does the attached >> patch help? >>> Unfortunately not. >> >> Maybe add a read

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-07 Thread Christian König
The GFX CP is split up into two different engines - the PFP and the ME (starting with SI you additionally get the CE as well). The PFP is responsible for reading commands out of memory and forwarding it to the ME (or the CE). Some commands can be executed on the PFP as well, like simple registe

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-07 Thread Marek Olšák
So what's difference between WRITE_DATA with PFP vs ME? Would it also be preferable for DMA_DATA and COPY_DATA? Marek On Thu, Aug 7, 2014 at 3:59 PM, Alex Deucher wrote: > On Thu, Aug 7, 2014 at 3:46 AM, Michel D?nzer wrote: >> From: Michel D?nzer >> >> Not doing this causes piglit hangs[0] on

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-07 Thread Michel Dänzer
From: Michel D?nzer Not doing this causes piglit hangs[0] on my Cape Verde card. No issues on Bonaire and Kaveri though. [0] Same symptoms as those fixed on CIK by 'drm/radeon: set VM base addr using the PFP v2'. Signed-off-by: Michel D?nzer --- drivers/gpu/drm/radeon/radeon_vm.c | 4 +++- 1

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-07 Thread Alex Deucher
On Thu, Aug 7, 2014 at 11:38 AM, Marek Ol??k wrote: > So what's difference between WRITE_DATA with PFP vs ME? Would it also > be preferable for DMA_DATA and COPY_DATA? The PFP comes before the ME in the pipeline. Note that there is no PFP (or CE) on the compute queues so we can't use PFP (or CE)

[PATCH] drm/radeon: Always flush VM again on < CIK

2014-08-07 Thread Alex Deucher
On Thu, Aug 7, 2014 at 3:46 AM, Michel D?nzer wrote: > From: Michel D?nzer > > Not doing this causes piglit hangs[0] on my Cape Verde card. No issues on > Bonaire and Kaveri though. > > [0] Same symptoms as those fixed on CIK by 'drm/radeon: set VM base addr > using the PFP v2'. > > Signed-off-by