Re: [PATCH] drm/print: Include drm_device.h

2025-01-25 Thread Lucas De Marchi
On Tue, 21 Jan 2025 18:09:25 -0300, Gustavo Sousa wrote: > The header drm_print.h uses members of struct drm_device pointers, as > such, it should include drm_device.h to let the compiler know the full > type definition. > > Without such include, users of drm_print.h that don't explicitly need >

Re: [PATCH] drm/print: Include drm_device.h

2025-01-23 Thread Simona Vetter
On Wed, Jan 22, 2025 at 04:49:21PM +0200, Jani Nikula wrote: > On Wed, 22 Jan 2025, Gustavo Sousa wrote: > > Quoting Jani Nikula (2025-01-22 11:02:31-03:00) > >>On Wed, 22 Jan 2025, Gustavo Sousa wrote: > >>> Quoting Simona Vetter (2025-01-22 08:11:53-03:00) > On Tue, Jan 21, 2025 at 06:09:25

Re: [PATCH] drm/print: Include drm_device.h

2025-01-22 Thread Jani Nikula
On Wed, 22 Jan 2025, Gustavo Sousa wrote: > Quoting Jani Nikula (2025-01-22 11:02:31-03:00) >>On Wed, 22 Jan 2025, Gustavo Sousa wrote: >>> Quoting Simona Vetter (2025-01-22 08:11:53-03:00) On Tue, Jan 21, 2025 at 06:09:25PM -0300, Gustavo Sousa wrote: > The header drm_print.h uses member

Re: [PATCH] drm/print: Include drm_device.h

2025-01-22 Thread Gustavo Sousa
Quoting Jani Nikula (2025-01-22 11:02:31-03:00) >On Wed, 22 Jan 2025, Gustavo Sousa wrote: >> Quoting Simona Vetter (2025-01-22 08:11:53-03:00) >>>On Tue, Jan 21, 2025 at 06:09:25PM -0300, Gustavo Sousa wrote: The header drm_print.h uses members of struct drm_device pointers, as such, it

Re: [PATCH] drm/print: Include drm_device.h

2025-01-22 Thread Jani Nikula
On Wed, 22 Jan 2025, Gustavo Sousa wrote: > Quoting Simona Vetter (2025-01-22 08:11:53-03:00) >>On Tue, Jan 21, 2025 at 06:09:25PM -0300, Gustavo Sousa wrote: >>> The header drm_print.h uses members of struct drm_device pointers, as >>> such, it should include drm_device.h to let the compiler know

Re: [PATCH] drm/print: Include drm_device.h

2025-01-22 Thread Gustavo Sousa
Quoting Simona Vetter (2025-01-22 08:11:53-03:00) >On Tue, Jan 21, 2025 at 06:09:25PM -0300, Gustavo Sousa wrote: >> The header drm_print.h uses members of struct drm_device pointers, as >> such, it should include drm_device.h to let the compiler know the full >> type definition. >> >> Without suc

Re: [PATCH] drm/print: Include drm_device.h

2025-01-22 Thread Simona Vetter
On Tue, Jan 21, 2025 at 06:09:25PM -0300, Gustavo Sousa wrote: > The header drm_print.h uses members of struct drm_device pointers, as > such, it should include drm_device.h to let the compiler know the full > type definition. > > Without such include, users of drm_print.h that don't explicitly ne

[PATCH] drm/print: Include drm_device.h

2025-01-21 Thread Gustavo Sousa
The header drm_print.h uses members of struct drm_device pointers, as such, it should include drm_device.h to let the compiler know the full type definition. Without such include, users of drm_print.h that don't explicitly need drm_device.h would bump into build errors and be forced to include the