Re: [PATCH] drm/panthor: fix building without CONFIG_DEBUG_FS

2025-04-24 Thread Adrián Larumbe
Hi Arnd, Thanks for the fix. I've already submitted a second attempt because I thought the build being broken is something we ought to deal with ASAP. I've added you as a bug reporter and also made mention of this thread in the new patch. Kind Regards, Adrian On 24.04.2025 13:25, Arnd Bergmann

Re: [PATCH] drm/panthor: fix building without CONFIG_DEBUG_FS

2025-04-24 Thread Boris Brezillon
On Thu, 24 Apr 2025 14:10:16 +0200 "Arnd Bergmann" wrote: > On Thu, Apr 24, 2025, at 13:41, Boris Brezillon wrote: > > On Thu, 24 Apr 2025 13:25:47 +0200 > >> +#ifdef CONFIG_DEBUG_FS > >>bo->debugfs.flags = usage_flags | > >> PANTHOR_DEBUGFS_GEM_USAGE_FLAG_INITIALIZED; > >> -} > >> - > >>

Re: [PATCH] drm/panthor: fix building without CONFIG_DEBUG_FS

2025-04-24 Thread Arnd Bergmann
On Thu, Apr 24, 2025, at 13:41, Boris Brezillon wrote: > On Thu, 24 Apr 2025 13:25:47 +0200 >> +#ifdef CONFIG_DEBUG_FS >> bo->debugfs.flags = usage_flags | >> PANTHOR_DEBUGFS_GEM_USAGE_FLAG_INITIALIZED; >> -} >> - >> -#else >> -void panthor_gem_debugfs_set_usage_flags(struct panthor_gem_objec

Re: [PATCH] drm/panthor: fix building without CONFIG_DEBUG_FS

2025-04-24 Thread Boris Brezillon
On Thu, 24 Apr 2025 13:25:47 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > When debugfs is disabled, including panthor_gem.h causes warnings > about a non-static global function defined in a header: > > In file included from drivers/gpu/drm/panthor/panthor_drv.c:30: > drivers/gpu/drm/pa

[PATCH] drm/panthor: fix building without CONFIG_DEBUG_FS

2025-04-24 Thread Arnd Bergmann
From: Arnd Bergmann When debugfs is disabled, including panthor_gem.h causes warnings about a non-static global function defined in a header: In file included from drivers/gpu/drm/panthor/panthor_drv.c:30: drivers/gpu/drm/panthor/panthor_gem.h:222:6: error: no previous prototype for 'panthor_ge