Re: [PATCH] drm/panthor: Fix memory leak in panthor_ioctl_group_create()

2025-07-18 Thread Steven Price
On 13/11/2024 21:03, Jann Horn wrote: > When bailing out due to group_priority_permit() failure, the queue_args > need to be freed. Fix it by rearranging the function to use the > goto-on-error pattern, such that the success case flows straight without > indentation while error cases jump forward t

Re: [PATCH] drm/panthor: Fix memory leak in panthor_ioctl_group_create()

2024-11-14 Thread Steven Price
On 13/11/2024 21:03, Jann Horn wrote: > When bailing out due to group_priority_permit() failure, the queue_args > need to be freed. Fix it by rearranging the function to use the > goto-on-error pattern, such that the success case flows straight without > indentation while error cases jump forward t

Re: [PATCH] drm/panthor: Fix memory leak in panthor_ioctl_group_create()

2024-11-14 Thread Liviu Dudau
On Wed, Nov 13, 2024 at 10:03:39PM +0100, Jann Horn wrote: > When bailing out due to group_priority_permit() failure, the queue_args > need to be freed. Fix it by rearranging the function to use the > goto-on-error pattern, such that the success case flows straight without > indentation while error

Re: [PATCH] drm/panthor: Fix memory leak in panthor_ioctl_group_create()

2024-11-13 Thread Boris Brezillon
On Wed, 13 Nov 2024 22:03:39 +0100 Jann Horn wrote: > When bailing out due to group_priority_permit() failure, the queue_args > need to be freed. Fix it by rearranging the function to use the > goto-on-error pattern, such that the success case flows straight without > indentation while error case

[PATCH] drm/panthor: Fix memory leak in panthor_ioctl_group_create()

2024-11-13 Thread Jann Horn
When bailing out due to group_priority_permit() failure, the queue_args need to be freed. Fix it by rearranging the function to use the goto-on-error pattern, such that the success case flows straight without indentation while error cases jump forward to cleanup. Cc: sta...@vger.kernel.org Fixes: