Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-07 Thread Boris Brezillon
On Tue, 4 Feb 2025 17:28:24 -0600 "Rob Herring (Arm)" wrote: > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > > Cc: Beata Michalska > Signed-off-by: Rob Herring (Arm) Queued to drm-misc-next.

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-06 Thread Steven Price
On 04/02/2025 23:28, Rob Herring (Arm) wrote: > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. Sounds like something that needs to be improved in bindgen... Never-the-less for this particular case I

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Rob Herring
On Wed, Feb 5, 2025 at 8:17 AM Erik Faye-Lund wrote: > > On Wed, 2025-02-05 at 11:53 +0100, Erik Faye-Lund wrote: > > On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote: > > > Use an enum instead of #defines for panthor IOCTLs. This allows the > > > header to be used with Rust code as bind

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Erik Faye-Lund
On Wed, 2025-02-05 at 11:53 +0100, Erik Faye-Lund wrote: > On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote: > > Use an enum instead of #defines for panthor IOCTLs. This allows the > > header to be used with Rust code as bindgen can't handle complex > > defines. > > > > > Unfortunately

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Boris Brezillon
On Tue, 4 Feb 2025 17:28:24 -0600 "Rob Herring (Arm)" wrote: > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > > Cc: Beata Michalska > Signed-off-by: Rob Herring (Arm) Acked-by: Boris Brezillo

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Erik Faye-Lund
On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote: > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > Unfortunately, this goes in the opposite direction than what I was asked to do here:

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Alice Ryhl
On Wed, Feb 5, 2025 at 12:30 AM Rob Herring (Arm) wrote: > > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > > Cc: Beata Michalska > Signed-off-by: Rob Herring (Arm) Reviewed-by: Alice Ryhl

[PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-04 Thread Rob Herring (Arm)
Use an enum instead of #defines for panthor IOCTLs. This allows the header to be used with Rust code as bindgen can't handle complex defines. Cc: Beata Michalska Signed-off-by: Rob Herring (Arm) --- include/uapi/drm/panthor_drm.h | 86 +- 1 file changed, 44 inser