Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-21 Thread Alice Ryhl
On 1/20/25 10:52 PM, Miguel Ojeda wrote: Hi Emmanuel, On Mon, Jan 20, 2025 at 1:45 PM Emmanuel Gil Peyrot wrote: In C, the char type is specified with “The implementation shall define char to have the same range, representation, and behavior as either signed char or unsigned char.” On x86 it

Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Miguel Ojeda
On Mon, Jan 20, 2025 at 11:03 PM Link Mauve wrote: > > when building with today’s nightly compiler (maybe that’s relevant?). Ah, that explains it! The type changes with beta (1.85.0), and I can also reproduce it in CE. We should probably try to backport the cleanups we did before the remapping,

Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Link Mauve
On Mon, Jan 20, 2025 at 10:52:48PM +0100, Miguel Ojeda wrote: > Hi Emmanuel, Hi Miguel, > > On Mon, Jan 20, 2025 at 1:45 PM Emmanuel Gil Peyrot > wrote: > > > > In C, the char type is specified with “The implementation shall define char > > to > > have the same range, representation, and behav

Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Miguel Ojeda
Hi Emmanuel, On Mon, Jan 20, 2025 at 1:45 PM Emmanuel Gil Peyrot wrote: > > In C, the char type is specified with “The implementation shall define char to > have the same range, representation, and behavior as either signed char or > unsigned char.” > > On x86 it defaults to signed char, and on A

[PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Emmanuel Gil Peyrot
In C, the char type is specified with “The implementation shall define char to have the same range, representation, and behavior as either signed char or unsigned char.” On x86 it defaults to signed char, and on ARM it defaults to unsigned char. This carries over to Rust’s FFI, which aliases its c