Re: [PATCH] drm/panfrost: Use upper/lower_32_bits helpers

2021-08-25 Thread Steven Price
On 24/08/2021 18:26, Alyssa Rosenzweig wrote: > Use upper_32_bits/lower_32_bits helpers instead of open-coding them. > This is easier to scan quickly compared to bitwise manipulation, and it > is pleasingly symmetric. I noticed this when debugging lock_region, > which had a particularly "creative"

Re: [PATCH] drm/panfrost: Use upper/lower_32_bits helpers

2021-08-24 Thread Rob Herring
On Tue, Aug 24, 2021 at 12:27 PM Alyssa Rosenzweig wrote: > > Use upper_32_bits/lower_32_bits helpers instead of open-coding them. > This is easier to scan quickly compared to bitwise manipulation, and it > is pleasingly symmetric. I noticed this when debugging lock_region, > which had a particula

[PATCH] drm/panfrost: Use upper/lower_32_bits helpers

2021-08-24 Thread Alyssa Rosenzweig
Use upper_32_bits/lower_32_bits helpers instead of open-coding them. This is easier to scan quickly compared to bitwise manipulation, and it is pleasingly symmetric. I noticed this when debugging lock_region, which had a particularly "creative" way of writing upper_32_bits. Signed-off-by: Alyssa R