Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-08 Thread Dmitry Osipenko
On 11/7/22 19:50, Robin Murphy wrote: > On 2022-11-04 20:48, Dmitry Osipenko wrote: >> On 11/4/22 23:37, Robin Murphy wrote: >>> On 2022-11-04 20:11, Dmitry Osipenko wrote: On 8/23/22 01:01, Robin Murphy wrote: > Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old >

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-07 Thread Robin Murphy
On 2022-11-04 20:48, Dmitry Osipenko wrote: On 11/4/22 23:37, Robin Murphy wrote: On 2022-11-04 20:11, Dmitry Osipenko wrote: On 8/23/22 01:01, Robin Murphy wrote: Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old single-page interfaces eventually go away. Unmapping heap B

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-04 Thread Dmitry Osipenko
On 11/4/22 23:37, Robin Murphy wrote: > On 2022-11-04 20:11, Dmitry Osipenko wrote: >> On 8/23/22 01:01, Robin Murphy wrote: >>> Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old >>> single-page interfaces eventually go away. Unmapping heap BOs still >>> wants to be done a page

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-04 Thread Robin Murphy
On 2022-11-04 20:11, Dmitry Osipenko wrote: On 8/23/22 01:01, Robin Murphy wrote: Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old single-page interfaces eventually go away. Unmapping heap BOs still wants to be done a page at a time, but everything else can get the full ben

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-04 Thread Dmitry Osipenko
On 8/23/22 01:01, Robin Murphy wrote: > Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old > single-page interfaces eventually go away. Unmapping heap BOs still > wants to be done a page at a time, but everything else can get the full > benefit of the more efficient interface. >

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-09-01 Thread Steven Price
On 22/08/2022 23:01, Robin Murphy wrote: > Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old > single-page interfaces eventually go away. Unmapping heap BOs still > wants to be done a page at a time, but everything else can get the full > benefit of the more efficient interface

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-08-31 Thread Alyssa Rosenzweig
On Tue, Aug 23, 2022 at 11:42:33AM +0100, Robin Murphy wrote: > On 2022-08-23 03:51, Alyssa Rosenzweig wrote: > > > -static size_t get_pgsize(u64 addr, size_t size) > > > +static size_t get_pgsize(u64 addr, size_t size, size_t *count) > > > { > > > - if (addr & (SZ_2M - 1) || size < SZ_2M) > > >

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-08-23 Thread Robin Murphy
On 2022-08-23 03:51, Alyssa Rosenzweig wrote: -static size_t get_pgsize(u64 addr, size_t size) +static size_t get_pgsize(u64 addr, size_t size, size_t *count) { - if (addr & (SZ_2M - 1) || size < SZ_2M) - return SZ_4K; + size_t blk_offset = -addr % SZ_2M; addr is uns

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-08-22 Thread Alyssa Rosenzweig
> -static size_t get_pgsize(u64 addr, size_t size) > +static size_t get_pgsize(u64 addr, size_t size, size_t *count) > { > - if (addr & (SZ_2M - 1) || size < SZ_2M) > - return SZ_4K; > + size_t blk_offset = -addr % SZ_2M; addr is unsigned. if this is correct, it's magic.

[PATCH] drm/panfrost: Update io-pgtable API

2022-08-22 Thread Robin Murphy
Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old single-page interfaces eventually go away. Unmapping heap BOs still wants to be done a page at a time, but everything else can get the full benefit of the more efficient interface. Signed-off-by: Robin Murphy --- drivers/gpu/