Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-14 Thread Alyssa Rosenzweig
> (Feedback for kernel patches on the same day, am I dreaming??) That's panfrost! > > Agreed, while the current implementation may be confusing it is at least > > self-consistent. TBH it would probably be sufficient to save the bother > > of allocating strings and just settle on "panfrost-{gpu,

Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-14 Thread Alyssa Rosenzweig
> TBH it would probably be sufficient to save the bother of allocating > strings and just settle on "panfrost-{gpu,job,mmu}", since upstream > users are unlikely to ever come across a system with more than one > Mali in it ;) Agreed. Wait, you said *upstream*? Are there oh no signature

Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-14 Thread Alyssa Rosenzweig
On Fri, Dec 13, 2019 at 03:31:45PM +, Robin Murphy wrote: > On 13/12/2019 2:32 pm, Alyssa Rosenzweig wrote: > > > TBH it would probably be sufficient to save the bother of allocating > > > strings and just settle on "panfrost-{gpu,job,mmu}", since upstream > > > users are unlikely to ever come

Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-13 Thread Ezequiel Garcia
Hey everyone, Thanks for the quick comments. (Feedback for kernel patches on the same day, am I dreaming??) On Fri, 2019-12-13 at 13:46 +, Robin Murphy wrote: > On 13/12/2019 1:18 pm, Neil Armstrong wrote: > > Hi, > > > > On 13/12/2019 13:39, Ezequiel Garcia wrote: > > > Currently, the inte

Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-13 Thread Robin Murphy
On 13/12/2019 2:32 pm, Alyssa Rosenzweig wrote: TBH it would probably be sufficient to save the bother of allocating strings and just settle on "panfrost-{gpu,job,mmu}", since upstream users are unlikely to ever come across a system with more than one Mali in it ;) Agreed. Wait, you said *

Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-13 Thread Robin Murphy
On 13/12/2019 1:18 pm, Neil Armstrong wrote: Hi, On 13/12/2019 13:39, Ezequiel Garcia wrote: Currently, the interrupt lines requested by Panfrost use ambiguous names, which adds some obscurity to interrupt introspection (i.e. any tool based on procfs' interrupts file). In order to improve this

Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-13 Thread Neil Armstrong
Hi, On 13/12/2019 13:39, Ezequiel Garcia wrote: > Currently, the interrupt lines requested by Panfrost > use ambiguous names, which adds some obscurity > to interrupt introspection (i.e. any tool based > on procfs' interrupts file). > > In order to improve this, prefix each requested > interrupt

[PATCH] drm/panfrost: Prefix interrupt handlers' names

2019-12-13 Thread Ezequiel Garcia
Currently, the interrupt lines requested by Panfrost use ambiguous names, which adds some obscurity to interrupt introspection (i.e. any tool based on procfs' interrupts file). In order to improve this, prefix each requested interrupt with either the module name or the device name, where possible.