Re: [PATCH] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-10-30 Thread Steven Price
On 30/10/2020 10:28, Boris Brezillon wrote: On Fri, 30 Oct 2020 10:00:07 + Steven Price wrote: On 30/10/2020 07:08, Boris Brezillon wrote: We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits

Re: [PATCH] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-10-30 Thread Boris Brezillon
On Fri, 30 Oct 2020 10:00:07 + Steven Price wrote: > On 30/10/2020 07:08, Boris Brezillon wrote: > > We've fixed many races in panfrost_job_timedout() but some remain. > > Instead of trying to fix it again, let's simplify the logic and move > > the reset bits to a separate work scheduled when

Re: [PATCH] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-10-30 Thread Steven Price
On 30/10/2020 07:08, Boris Brezillon wrote: We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. Fixes: 1a11a88cfd9a ("drm/panfr

[PATCH] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-10-30 Thread Boris Brezillon
We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. Fixes: 1a11a88cfd9a ("drm/panfrost: Fix job timeout handling") Cc: Signed-of