Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-09 Thread Steven Price
On 07/10/2019 17:14, Tomeu Vizoso wrote: > On 10/7/19 6:09 AM, Neil Armstrong wrote: >> Hi Steven, >> >> On 07/10/2019 14:50, Steven Price wrote: >>> Panfrost uses multiple schedulers (one for each slot, so 2 in reality), >>> and on a timeout has to stop all the schedulers to safely perform a >>> r

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-08 Thread Neil Armstrong
On 07/10/2019 14:50, Steven Price wrote: > Panfrost uses multiple schedulers (one for each slot, so 2 in reality), > and on a timeout has to stop all the schedulers to safely perform a > reset. However more than one scheduler can trigger a timeout at the same > time. This race condition results in

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-07 Thread Tomeu Vizoso
On 10/7/19 6:09 AM, Neil Armstrong wrote: Hi Steven, On 07/10/2019 14:50, Steven Price wrote: Panfrost uses multiple schedulers (one for each slot, so 2 in reality), and on a timeout has to stop all the schedulers to safely perform a reset. However more than one scheduler can trigger a timeout

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-07 Thread Neil Armstrong
Hi Steven, On 07/10/2019 14:50, Steven Price wrote: > Panfrost uses multiple schedulers (one for each slot, so 2 in reality), > and on a timeout has to stop all the schedulers to safely perform a > reset. However more than one scheduler can trigger a timeout at the same > time. This race condition

[PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-07 Thread Steven Price
Panfrost uses multiple schedulers (one for each slot, so 2 in reality), and on a timeout has to stop all the schedulers to safely perform a reset. However more than one scheduler can trigger a timeout at the same time. This race condition results in jobs being freed while they are still in use. Wh