Re: [PATCH] drm/panfrost: Fix module unload

2020-11-03 Thread Boris Brezillon
On Fri, 30 Oct 2020 14:58:33 + Steven Price wrote: > When unloading the call to pm_runtime_put_sync_suspend() will attempt to > turn the GPU cores off, however panfrost_device_fini() will have turned > the clocks off. This leads to the hardware locking up. > > Instead don't call pm_runtime_p

Re: [PATCH] drm/panfrost: Fix module unload

2020-11-03 Thread Tomeu Vizoso
Looks good, thanks! Reviewed-by: Tomeu Vizoso On Fri, 30 Oct 2020 at 15:59, Steven Price wrote: > When unloading the call to pm_runtime_put_sync_suspend() will attempt to > turn the GPU cores off, however panfrost_device_fini() will have turned > the clocks off. This leads to the hardware lock

[PATCH] drm/panfrost: Fix module unload

2020-10-30 Thread Steven Price
When unloading the call to pm_runtime_put_sync_suspend() will attempt to turn the GPU cores off, however panfrost_device_fini() will have turned the clocks off. This leads to the hardware locking up. Instead don't call pm_runtime_put_sync_suspend() and instead simply mark the device as suspended u