Re: [PATCH] drm/panfrost: Export all GPU feature registers

2019-07-24 Thread Alyssa Rosenzweig
> I think this ship already sailed when we added the first one with > GPU_ID. Also, at least etnaviv works the same way. Fair enough then! Reviewed-by: Alyssa Rosenzweig signature.asc Description: PGP signature

Re: [PATCH] drm/panfrost: Export all GPU feature registers

2019-07-24 Thread Rob Herring
On Wed, Jul 24, 2019 at 10:40 AM Alyssa Rosenzweig wrote: > > This is definitely helpful! > > My one concern is, supposing userspace really does need all of this > information, is it wasteful to have to do 30+ ioctls just to get this? > kbase had a single ioctl to grab all of the properties, wheth

Re: [PATCH] drm/panfrost: Export all GPU feature registers

2019-07-24 Thread Alyssa Rosenzweig
This is definitely helpful! My one concern is, supposing userspace really does need all of this information, is it wasteful to have to do 30+ ioctls just to get this? kbase had a single ioctl to grab all of the properties, whether userspace wanted them or not. I'm not sure if that's better -- the

Re: [PATCH] drm/panfrost: Export all GPU feature registers

2019-07-24 Thread Rob Herring
Adding Alyssa's Collabora email. On Wed, Jul 24, 2019 at 4:56 AM Steven Price wrote: > > Midgard/Bifrost GPUs have a bunch of feature registers providing details > of what the hardware supports. Panfrost already reads these, this patch > exports them all to user space so that the jobs created by

[PATCH] drm/panfrost: Export all GPU feature registers

2019-07-24 Thread Steven Price
Midgard/Bifrost GPUs have a bunch of feature registers providing details of what the hardware supports. Panfrost already reads these, this patch exports them all to user space so that the jobs created by the user space driver can be tuned for the particular hardware implementation. Signed-off-by: