Re: [PATCH] drm/panfrost: Don't try to map on error faults

2020-02-06 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Although it might be nice to #define TRANSLATION_FAULT_LEVEL1 0xC1 ... #define TRANSLATION_FAULT_LEVEL4 0xC4 and then use semantic names instead of magic values. Minimally maybe add a comment explaining that. On Wed, Feb 05, 2020 at 11:07

Re: [PATCH] drm/panfrost: Don't try to map on error faults

2020-02-05 Thread Steven Price
On 05/02/2020 13:25, Robin Murphy wrote: > On 05/02/2020 10:07 am, Tomeu Vizoso wrote: >> If the exception type isn't one of the normal faults, don't try to map >> and instead go straight to a terminal fault. > > "One of the the normal faults" seems a rather vague way of saying "a > translation fa

Re: [PATCH] drm/panfrost: Don't try to map on error faults

2020-02-05 Thread Robin Murphy
On 05/02/2020 10:07 am, Tomeu Vizoso wrote: If the exception type isn't one of the normal faults, don't try to map and instead go straight to a terminal fault. "One of the the normal faults" seems a rather vague way of saying "a translation fault", which is what we're specifically handling her

[PATCH] drm/panfrost: Don't try to map on error faults

2020-02-05 Thread Tomeu Vizoso
If the exception type isn't one of the normal faults, don't try to map and instead go straight to a terminal fault. Otherwise, we can get flooded by kernel warnings and further faults. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 +++-- 1 file changed, 3 insertion