Re: [PATCH] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove

2024-07-09 Thread Doug Anderson
Hi, On Tue, Jul 9, 2024 at 12:53 AM Neil Armstrong wrote: > > On 08/07/2024 19:52, Douglas Anderson wrote: > > Commit d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable > > at shutdown/remove") had a subtle bug. We should be calling > > sharp_panel_del() when the "sharp" variable is

Re: [PATCH] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove

2024-07-09 Thread Neil Armstrong
On 08/07/2024 19:52, Douglas Anderson wrote: Commit d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove") had a subtle bug. We should be calling sharp_panel_del() when the "sharp" variable is non-NULL, not when it's NULL. Fix. Fixes: d7d473d8464e ("drm/panel: sharp

[PATCH] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove

2024-07-08 Thread Douglas Anderson
Commit d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove") had a subtle bug. We should be calling sharp_panel_del() when the "sharp" variable is non-NULL, not when it's NULL. Fix. Fixes: d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/r