Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-19 Thread Jakob Hauser
Hi all, On 16.06.23 01:36, Doug Anderson wrote: ... I guess the tl;dr (summary of my summary) is: a) Moving panels like this to "pre_enable_prev_first" seems like a reasonable idea anyway and (presumably) works around the issue. b) Moving some commands between disable() / post_diable() or pre_

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-19 Thread Jakob Hauser
A typo in my previous e-mail: On 18.06.23 15:47, Jakob Hauser wrote: ... Then the panel get's turned off: ... should be "When..." instead of "Then...".

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-15 Thread Doug Anderson
Hi, On Thu, Jun 15, 2023 at 12:49 AM Neil Armstrong wrote: > > On 14/06/2023 22:58, Linus Walleij wrote: > > On Tue, Jun 13, 2023 at 11:08 PM Stephan Gerhold > > wrote: > > > >> I'm still quite confused about what exactly is supposed to be in > >> (un)prepare and what in enable/disable. I've se

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-15 Thread Stephan Gerhold
On Thu, Jun 15, 2023 at 09:49:27AM +0200, Neil Armstrong wrote: > On 14/06/2023 22:58, Linus Walleij wrote: > > On Tue, Jun 13, 2023 at 11:08 PM Stephan Gerhold > > wrote: > > > > > I'm still quite confused about what exactly is supposed to be in > > > (un)prepare and what in enable/disable. I'v

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-15 Thread Neil Armstrong
On 14/06/2023 22:58, Linus Walleij wrote: On Tue, Jun 13, 2023 at 11:08 PM Stephan Gerhold wrote: I'm still quite confused about what exactly is supposed to be in (un)prepare and what in enable/disable. I've seen some related discussion every now and then but it's still quite inconsistent acro

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-14 Thread Linus Walleij
On Tue, Jun 13, 2023 at 11:08 PM Stephan Gerhold wrote: > I'm still quite confused about what exactly is supposed to be in > (un)prepare and what in enable/disable. I've seen some related > discussion every now and then but it's still quite inconsistent across > different panel drivers... Can som

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-13 Thread Stephan Gerhold
[added Dmitry to Cc, since he suggested doing this in [1]] On Tue, Jun 13, 2023 at 12:36:52AM +0100, Caleb Connolly wrote: > The commit 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE") > breaks panels which send DSI commands in their .unprepare callbacks. > Migrate to using .disable for th

[PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-12 Thread Caleb Connolly
The commit 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE") breaks panels which send DSI commands in their .unprepare callbacks. Migrate to using .disable for that for some SDM845 panels. Co-developed-by: Joel Selvaraj Signed-off-by: Joel Selvaraj Signed-off-by: Caleb Connolly --- base-