Re: [PATCH] drm/omapdrm: Switch to gem_free_object_unlocked

2018-04-03 Thread Laurent Pinchart
Hi Daniel, On Tuesday, 3 April 2018 12:07:31 EEST Daniel Vetter wrote: > On Mon, Apr 02, 2018 at 06:05:22PM +0300, Laurent Pinchart wrote: > > On Thursday, 29 March 2018 12:41:33 EEST Tomi Valkeinen wrote: > >> On 28/03/18 14:41, Daniel Vetter wrote: > >>> The only thing that omap_gem_free_object

Re: [PATCH] drm/omapdrm: Switch to gem_free_object_unlocked

2018-04-03 Thread Daniel Vetter
On Mon, Apr 02, 2018 at 06:05:22PM +0300, Laurent Pinchart wrote: > Hello, > > On Thursday, 29 March 2018 12:41:33 EEST Tomi Valkeinen wrote: > > On 28/03/18 14:41, Daniel Vetter wrote: > > > The only thing that omap_gem_free_object does that might need the > > > magic protection of struct_mutex (

Re: [PATCH] drm/omapdrm: Switch to gem_free_object_unlocked

2018-04-02 Thread Laurent Pinchart
Hello, On Thursday, 29 March 2018 12:41:33 EEST Tomi Valkeinen wrote: > On 28/03/18 14:41, Daniel Vetter wrote: > > The only thing that omap_gem_free_object does that might need the > > magic protection of struct_mutex (of keeping all objects alive if that > > lock is held, even if the last refere

Re: [PATCH] drm/omapdrm: Switch to gem_free_object_unlocked

2018-03-29 Thread Tomi Valkeinen
On 28/03/18 14:41, Daniel Vetter wrote: > The only thing that omap_gem_free_object does that might need the > magic protection of struct_mutex (of keeping all objects alive if that > lock is held, even if the last reference is gone) is the mm_list > manipulation. > > But that is already protected

[PATCH] drm/omapdrm: Switch to gem_free_object_unlocked

2018-03-28 Thread Daniel Vetter
The only thing that omap_gem_free_object does that might need the magic protection of struct_mutex (of keeping all objects alive if that lock is held, even if the last reference is gone) is the mm_list manipulation. But that is already protected by the separate omapdrm->list_lock, which means stru