Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-09 Thread Tony Lindgren
* Matthijs van Duin [200106 10:07]: > On Sun, Jan 05, 2020 at 12:37:04PM -0800, Tony Lindgren wrote: > > 4. The issue I'm seeing with stellarium on droid4 may be a stride > >issue as about one out of 3 or 4 frames is OK and aligning to > >512 also fixes the issue maybe because it happens t

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-07 Thread Tomi Valkeinen
On 07/01/2020 15:30, Tomi Valkeinen wrote: On 05/01/2020 22:37, Tony Lindgren wrote: Hi, * Tony Lindgren [200104 05:51]: Just changing the alingment fixes the issue. Looks like the minimum alignment we currently allow is 128, I think 512 was the minimum that worked for me, so maybe the right

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-07 Thread Tomi Valkeinen
On 05/01/2020 22:37, Tony Lindgren wrote: Hi, * Tony Lindgren [200104 05:51]: Just changing the alingment fixes the issue. Looks like the minimum alignment we currently allow is 128, I think 512 was the minimum that worked for me, so maybe the right fix would be to just change the minimum to

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-07 Thread Matthijs van Duin
On Sun, Jan 05, 2020 at 12:37:04PM -0800, Tony Lindgren wrote: > - Linux use of tiler aligned to 128 bytes which is presumably a simplification of the alignment imposed by hardware: - 64 bytes (64 pixels) for 8bpp - 128 bytes (64 pixels) for 16bpp - 128 bytes (32 pixels) for 32bpp > - Fast user

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-06 Thread Tony Lindgren
Hi, * Tony Lindgren [200104 05:51]: > > Just changing the alingment fixes the issue. Looks like the minimum > alignment we currently allow is 128, I think 512 was the minimum > that worked for me, so maybe the right fix would be to just change > the minimum to 512 with no specific need to use 40

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-04 Thread Tony Lindgren
* Matthijs van Duin [200104 04:53]: > On Fri, Dec 20, 2019 at 04:57:11PM -0800, Tony Lindgren wrote: > > On my droid4 I noticed bad constant tearing on the LCD with stellarium in > > landscape mode with xorg-video-omap rotated with xrandr --rotate right. > > Every second or so update gets squeezed

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-04 Thread Tony Lindgren
* Matthijs van Duin [200104 05:10]: > On Sat, Dec 21, 2019 at 08:41:41AM -0800, Tony Lindgren wrote: > > Also, I'm wondering if this change makes sense alone without the pinning > > changes for a fix, or if also the pinning changes are needed. > > Both pinning and page-alignment are done just to

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-04 Thread Matthijs van Duin
On Sat, Dec 21, 2019 at 08:41:41AM -0800, Tony Lindgren wrote: > Also, I'm wondering if this change makes sense alone without the pinning > changes for a fix, or if also the pinning changes are needed. Both pinning and page-alignment are done just to support the direct userspace mapping. By thems

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2020-01-04 Thread Matthijs van Duin
On Fri, Dec 20, 2019 at 04:57:11PM -0800, Tony Lindgren wrote: > On my droid4 I noticed bad constant tearing on the LCD with stellarium in > landscape mode with xorg-video-omap rotated with xrandr --rotate right. > Every second or so update gets squeezed down in size to only the top half > of the L

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2019-12-23 Thread Tony Lindgren
* Tony Lindgren [191220 16:57]: > Looking around what might affect BO_TILED, I noticed Matthijs had this > change in his earlier pyra tiler patches. The earlier patch "XXX omapdrm: > force tiled buffers to be pinned and page-aligned" has no commit log > though, so I'm not sure what other issues th

[PATCH] drm/omap: gem: Fix tearing with BO_TILED

2019-12-23 Thread Tony Lindgren
On my droid4 I noticed bad constant tearing on the LCD with stellarium in landscape mode with xorg-video-omap rotated with xrandr --rotate right. Every second or so update gets squeezed down in size to only the top half of the LCD panel. This issue does not happen with xrandr --rotate normal, or w