Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-08-07 Thread Maarten Lankhorst
Op 04-08-17 om 12:02 schreef Daniel Vetter: > On Fri, Aug 4, 2017 at 11:57 AM, Tomi Valkeinen wrote: >>> Here you go, compile tested version. :) >>> 8< >>> I want/need to rework the core property handling, and this hack is >>> getting in the way. But since it's a non-standard propety only

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-08-07 Thread Maarten Lankhorst
Op 04-08-17 om 12:02 schreef Daniel Vetter: > On Fri, Aug 4, 2017 at 11:57 AM, Tomi Valkeinen wrote: >>> Here you go, compile tested version. :) >>> 8< >>> I want/need to rework the core property handling, and this hack is >>> getting in the way. But since it's a non-standard propety only

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-08-04 Thread Daniel Vetter
On Fri, Aug 4, 2017 at 11:57 AM, Tomi Valkeinen wrote: >> Here you go, compile tested version. :) >> 8< >> I want/need to rework the core property handling, and this hack is >> getting in the way. But since it's a non-standard propety only used by >> legacy userspace we know that this will

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-08-04 Thread Tomi Valkeinen
Hi, > Here you go, compile tested version. :) > 8< > I want/need to rework the core property handling, and this hack is > getting in the way. But since it's a non-standard propety only used by > legacy userspace we know that this will only every be called from > ioctl code. And never on so

[PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-08-02 Thread Maarten Lankhorst
Op 02-08-17 om 10:02 schreef Daniel Vetter: > On Tue, Aug 1, 2017 at 12:20 PM, Laurent Pinchart > wrote: >> On Tuesday 01 Aug 2017 07:59:13 Maarten Lankhorst wrote: >>> + pri_state = drm_atomic_get_new_plane_state(crtc->primary, >>> state->state); >>> + if (pri_state) { >>> +

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-08-02 Thread Daniel Vetter
On Tue, Aug 1, 2017 at 12:20 PM, Laurent Pinchart wrote: > On Tuesday 01 Aug 2017 07:59:13 Maarten Lankhorst wrote: >> + pri_state = drm_atomic_get_new_plane_state(crtc->primary, >> state->state); >> + if (pri_state) { >> + struct omap_crtc_state *omap_crtc_state = >> +

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-08-01 Thread Laurent Pinchart
Hi Maarten, On Tuesday 01 Aug 2017 07:59:13 Maarten Lankhorst wrote: > Op 31-07-17 om 17:42 schreef Daniel Vetter: > > I want/need to rework the core property handling, and this hack is > > getting in the way. But since it's a non-standard propety only used by > > legacy userspace we know that thi

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-07-31 Thread Maarten Lankhorst
Op 31-07-17 om 17:42 schreef Daniel Vetter: > I want/need to rework the core property handling, and this hack is > getting in the way. But since it's a non-standard propety only used by > legacy userspace we know that this will only every be called from > ioctl code. And never on some other free-st

[PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-07-31 Thread Daniel Vetter
I want/need to rework the core property handling, and this hack is getting in the way. But since it's a non-standard propety only used by legacy userspace we know that this will only every be called from ioctl code. And never on some other free-standing state struct, where this old hack wouldn't wo

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-07-31 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Monday 31 Jul 2017 14:45:16 Daniel Vetter wrote: > I want/need to rework the core property handling, and this hack is > getting in the way. But since it's a non-standard propety only used by > legacy userspace we know that this will only every be called from

[PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-07-31 Thread Daniel Vetter
I want/need to rework the core property handling, and this hack is getting in the way. But since it's a non-standard propety only used by legacy userspace we know that this will only every be called from ioctl code. And never on some other free-standing state struct, where this old hack wouldn't wo

Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-07-31 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Monday 31 Jul 2017 12:54:19 Daniel Vetter wrote: > I want/need to rework the core property handling, and this hack is > getting in the way. But since it's a non-standard propety only used by s/propety/property/ > legacy userspace we know that this will onl

[PATCH] drm/omap: Rework the rotation-on-crtc hack

2017-07-31 Thread Daniel Vetter
I want/need to rework the core property handling, and this hack is getting in the way. But since it's a non-standard propety only used by legacy userspace we know that this will only every be called from ioctl code. And never on some other free-standing state struct, where this old hack wouldn't wo