Re: [PATCH] drm/omap: Fix issue with clocks left on after resume

2021-04-28 Thread Tony Lindgren
* Tony Lindgren [210427 10:54]: > * Tony Lindgren [210427 10:12]: > > * Tomi Valkeinen [210427 08:47]: > > > If I understand right, this is only an issue when the dss was not enabled > > > before the system suspend? And as the dispc is not enabled at suspend, > > > pm_runtime_force_suspend and p

Re: [PATCH] drm/omap: Fix issue with clocks left on after resume

2021-04-27 Thread Tony Lindgren
* Tony Lindgren [210427 10:12]: > * Tomi Valkeinen [210427 08:47]: > > If I understand right, this is only an issue when the dss was not enabled > > before the system suspend? And as the dispc is not enabled at suspend, > > pm_runtime_force_suspend and pm_runtime_force_resume don't really do > >

Re: [PATCH] drm/omap: Fix issue with clocks left on after resume

2021-04-27 Thread Tony Lindgren
Hi, * Tomi Valkeinen [210427 08:47]: > Hi Tony, > > On 26/04/2021 17:12, Tony Lindgren wrote: > > On resume, dispc pm_runtime_force_resume() is not enabling the hardware > > as we pass the pm_runtime_need_not_resume() test as the device is suspended > > with no child devices. > > > > As the res

Re: [PATCH] drm/omap: Fix issue with clocks left on after resume

2021-04-27 Thread Tomi Valkeinen
Hi Tony, On 26/04/2021 17:12, Tony Lindgren wrote: On resume, dispc pm_runtime_force_resume() is not enabling the hardware as we pass the pm_runtime_need_not_resume() test as the device is suspended with no child devices. As the resume continues, omap_atomic_comit_tail() calls dispc_runtime_get

[PATCH] drm/omap: Fix issue with clocks left on after resume

2021-04-26 Thread Tony Lindgren
On resume, dispc pm_runtime_force_resume() is not enabling the hardware as we pass the pm_runtime_need_not_resume() test as the device is suspended with no child devices. As the resume continues, omap_atomic_comit_tail() calls dispc_runtime_get() that calls rpm_resume() enabling the hardware, and