[PATCH] drm/nouveau: idle all channels before suspending

2013-04-09 Thread Ben Skeggs
On Mon, Apr 8, 2013 at 10:04 PM, Maarten Lankhorst < maarten.lankhorst at canonical.com> wrote: > Seems to make suspend slightly more reliable on my system. > NACK. "Seems to", and "slightly" don't make a very good argument for this. Likely all you've done is change the timing of certain things

[PATCH] drm/nouveau: idle all channels before suspending

2013-04-09 Thread Maarten Lankhorst
Op 09-04-13 01:14, Ben Skeggs schreef: > On Mon, Apr 8, 2013 at 10:04 PM, Maarten Lankhorst < > maarten.lankhorst at canonical.com> wrote: > >> Seems to make suspend slightly more reliable on my system. >> > NACK. > > "Seems to", and "slightly" don't make a very good argument for this. > Likely al

Re: [PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Maarten Lankhorst
Op 09-04-13 01:14, Ben Skeggs schreef: > On Mon, Apr 8, 2013 at 10:04 PM, Maarten Lankhorst < > maarten.lankho...@canonical.com> wrote: > >> Seems to make suspend slightly more reliable on my system. >> > NACK. > > "Seems to", and "slightly" don't make a very good argument for this. > Likely all y

Re: [PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Ben Skeggs
On Mon, Apr 8, 2013 at 10:04 PM, Maarten Lankhorst < maarten.lankho...@canonical.com> wrote: > Seems to make suspend slightly more reliable on my system. > NACK. "Seems to", and "slightly" don't make a very good argument for this. Likely all you've done is change the timing of certain things hap

[PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Maarten Lankhorst
Seems to make suspend slightly more reliable on my system. Cc: stable at vger.kernel.org [3.7+] Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index b6bdc9f..5032c31 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.

[PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Maarten Lankhorst
Seems to make suspend slightly more reliable on my system. Cc: sta...@vger.kernel.org [3.7+] Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index b6bdc9f..5032c31 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +