Thanks for the patch, some notes below.
On Mon, Dec 16, 2024 at 09:52:46AM +0800, Zhanxin Qi wrote:
> The nvbios_iccsense_parse function allocates memory for sensor data
> but fails to free it when the function exits, leading to a memory
> leak. Add proper cleanup to free the allocated memory.
>
The nvbios_iccsense_parse function allocates memory for sensor data
but fails to free it when the function exits, leading to a memory
leak. Add proper cleanup to free the allocated memory.
Signed-off-by: Zhanxin Qi
---
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 +++
1 file changed,
0001-drm-nouveau-Fix-memory-leak-in-nvbios_iccsense_parse.patch
Description: 0001-drm-nouveau-Fix-memory-leak-in-nvbios_iccsense_parse.patch
0001-drm-nouveau-Fix-memory-leak-in-nvbios_iccsense_parse.patch
Description: Binary data
kmemleak report:
unreferenced object 0x9071c65644e0 (size 96):
comm "systemd-udevd", pid 347, jiffies 4294898424 (age 810.828s)
hex dump (first 32 bytes):
02 01 00 00 00 00 00 00 00 00 10 00 02 04 00 00
00 00 00 00 00 00 a0 86 00 00 00 00 00 00 00 00 ...
ping ...
On Tue, Nov 26, 2019 at 11:50 AM Navid Emamdoost
wrote:
>
> ping...
>
> On Thu, Nov 21, 2019 at 12:09 PM Navid Emamdoost
> wrote:
> >
> > On Mon, Oct 21, 2019 at 4:14 PM Navid Emamdoost
> > wrote:
> > >
> > > In the implementation of nouveau_bo_alloc() if it fails to determine the
> >
ping...
On Thu, Nov 21, 2019 at 12:09 PM Navid Emamdoost
wrote:
>
> On Mon, Oct 21, 2019 at 4:14 PM Navid Emamdoost
> wrote:
> >
> > In the implementation of nouveau_bo_alloc() if it fails to determine the
> > target page size via pi, then the allocated memory for nvbo should be
> > released.
>
On Mon, Oct 21, 2019 at 4:14 PM Navid Emamdoost
wrote:
>
> In the implementation of nouveau_bo_alloc() if it fails to determine the
> target page size via pi, then the allocated memory for nvbo should be
> released.
>
> Fixes: 019cbd4a4feb ("drm/nouveau: Initialize GEM object before TTM object")
>
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -276,8 +276,10 @@ nouveau_bo_alloc(struct nouveau_cli *cli, u64 *size, int
> *align, u32 flags,
> break;
> }
>
> - if (WARN_ON(pi < 0))
> + if (WARN_ON(pi < 0)) {
> + kfree(nvbo);
> retu
In the implementation of nouveau_bo_alloc() if it fails to determine the
target page size via pi, then the allocated memory for nvbo should be
released.
Fixes: 019cbd4a4feb ("drm/nouveau: Initialize GEM object before TTM object")
Signed-off-by: Navid Emamdoost
---
drivers/gpu/drm/nouveau/nouveau
.org
> Cc: nouv...@lists.freedesktop.org; Wei, Yunguo (Bryan); Gortmaker, Paul
> Subject: [Nouveau] [PATCH] drm/nouveau: Fix memory leak in nvkm_ram_get()
>
> When resuming from ACPI S3, memory leak happens in nvkm_ram_get().
> This is because *pmemory points to newly allocated memory without
When resuming from ACPI S3, memory leak happens in nvkm_ram_get().
This is because *pmemory points to newly allocated memory without
checking and freeing the old memory.
Here is the log showing this issue.
unreferenced object 0xa3b608c6d5c0 (size 64):
comm "kworker/u32:30", pid 934, jiffies
On Mon, 1 Jul 2019 at 12:37, Yongxin Liu wrote:
>
> In nouveau_conn_reset(), if connector->state is true,
> __drm_atomic_helper_connector_destroy_state() will be called,
> but the memory pointed by asyc isn't freed. Memory leak happens
> in the following function __drm_atomic_helper_connector_rese
In nouveau_conn_reset(), if connector->state is true,
__drm_atomic_helper_connector_destroy_state() will be called,
but the memory pointed by asyc isn't freed. Memory leak happens
in the following function __drm_atomic_helper_connector_reset(),
where newly allocated asyc->state will be assigned to
v4.19.8, it's ok to skip v4.14 for this
On Wed, 2018-12-12 at 05:46 +, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: f479c0ba4a17 drm/nouveau/kms/nv50: initial support for DP 1.2
> multi-strea
Hi,
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag,
fixing commit: f479c0ba4a17 drm/nouveau/kms/nv50: initial support for DP 1.2
multi-stream.
The bot has tested the following trees: v4.19.8, v4.14.87,
v4.19.8: Build OK!
v4.14.87: Failed to appl
Noticed this while working on redoing the reference counting scheme in
the DP MST helpers. Nouveau doesn't attempt to call
drm_dp_mst_topology_mgr_destroy() at all, which leaves it leaking all of
the resources for drm_dp_mst_topology_mgr and it's children mstbs+ports.
Fixes: f479c0ba4a17 ("drm/nou
On Thu, Oct 08, 2015 at 03:22:20PM +0100, Emil Velikov wrote:
> On 8 October 2015 at 14:00, Sudip Mukherjee
> wrote:
> > On Thu, Oct 01, 2015 at 04:40:59PM +1000, Ben Skeggs wrote:
> >> On 09/25/2015 01:59 AM, Sudip Mukherjee wrote:
> >> > On Fri, Sep 11, 2015 at 03:00:56PM +0530, Sudip Mukherjee
On Thu, Oct 01, 2015 at 04:40:59PM +1000, Ben Skeggs wrote:
> On 09/25/2015 01:59 AM, Sudip Mukherjee wrote:
> > On Fri, Sep 11, 2015 at 03:00:56PM +0530, Sudip Mukherjee wrote:
> >> If pm_runtime_get_sync() we were going to "out" but we missed
> >> freeing vma.
> >>
> >> Signed-off-by: Sudip Mukh
On 8 October 2015 at 14:00, Sudip Mukherjee
wrote:
> On Thu, Oct 01, 2015 at 04:40:59PM +1000, Ben Skeggs wrote:
>> On 09/25/2015 01:59 AM, Sudip Mukherjee wrote:
>> > On Fri, Sep 11, 2015 at 03:00:56PM +0530, Sudip Mukherjee wrote:
>> >> If pm_runtime_get_sync() we were going to "out" but we mis
On Thu, Oct 01, 2015 at 04:40:59PM +1000, Ben Skeggs wrote:
> On 09/25/2015 01:59 AM, Sudip Mukherjee wrote:
> > On Fri, Sep 11, 2015 at 03:00:56PM +0530, Sudip Mukherjee wrote:
> >> If pm_runtime_get_sync() we were going to "out" but we missed
> >> freeing vma.
> >>
> >> Signed-off-by: Sudip Mukh
On 09/25/2015 01:59 AM, Sudip Mukherjee wrote:
> On Fri, Sep 11, 2015 at 03:00:56PM +0530, Sudip Mukherjee wrote:
>> If pm_runtime_get_sync() we were going to "out" but we missed
>> freeing vma.
>>
>> Signed-off-by: Sudip Mukherjee ---
> Hi Ben, Another gentle ping for another patch.
Both patches
On Fri, Sep 11, 2015 at 03:00:56PM +0530, Sudip Mukherjee wrote:
> If pm_runtime_get_sync() we were going to "out" but we missed freeing
> vma.
>
> Signed-off-by: Sudip Mukherjee
> ---
Hi Ben,
Another gentle ping for another patch.
regards
sudip
If pm_runtime_get_sync() we were going to "out" but we missed freeing
vma.
Signed-off-by: Sudip Mukherjee
---
drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c
b/drivers/gpu/drm/nouveau/nouveau_gem.
Hi Dongxing Zhang,
On 11 June 2015 at 09:14, Dongxing Zhang wrote:
> unreferenced object 0x8800bd132fe8 (size 256):
> comm "Xorg", pid 1260, jiffies 4294901661 (age 660.504s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 e8 2f 13 bd 00 88 ff ff ./..
> 01 00 0
unreferenced object 0x8800bd132fe8 (size 256):
comm "Xorg", pid 1260, jiffies 4294901661 (age 660.504s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 e8 2f 13 bd 00 88 ff ff ./..
01 00 00 00 ff ff ff ff 00 00 00 00 00 00 00 00
backtrace:
[]
26 matches
Mail list logo
