Re: [Nouveau] [PATCH] drm/nouveau: fix an error code in nouveau_backlight_init()

2021-04-19 Thread Pierre Moreau
I can not remember why the original code did return 0 rather than an error, but -ENOMEM seems indeed way more fitting. Reviewed-by: Pierre Moreau On 2021-04-14 — 08:58, Dan Carpenter wrote: > If nouveau_get_backlight_name() fails then this should return -ENOMEM > but currently it returns success

[PATCH] drm/nouveau: fix an error code in nouveau_backlight_init()

2021-04-13 Thread Dan Carpenter
If nouveau_get_backlight_name() fails then this should return -ENOMEM but currently it returns success. Fixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces") Signed-off-by: Dan Carpenter --- This is from static analysis. In the original commit db1a0ae21461 ("drm/nouveau/bl