Re: [Nouveau] [PATCH] drm/nouveau: Fix NULL ptr access in nv50_wndw_prepare_fb()

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 06:28:47AM +0100, Thomas Zimmermann wrote: > Hi > > I'm surprised that prepare_fb is called with fb == NULL. But, OK Yeah we don't filter that ... maybe an oversight? I'm not sure whether there's any driver that needs to do something special for when the plane is disabled

Re: [PATCH] drm/nouveau: Fix NULL ptr access in nv50_wndw_prepare_fb()

2020-02-10 Thread Thomas Zimmermann
Hi I'm surprised that prepare_fb is called with fb == NULL. But, OK Acked-by: Thomas Zimmermann Thanks for the fix. Am 11.02.20 um 00:09 schrieb James Jones: > This fixes a kernel oops when loading the nouveau > module with fb console enabled after the change: > > drm/nouveau: Remove field

[PATCH] drm/nouveau: Fix NULL ptr access in nv50_wndw_prepare_fb()

2020-02-10 Thread James Jones
This fixes a kernel oops when loading the nouveau module with fb console enabled after the change: drm/nouveau: Remove field nvbo from struct nouveau_framebuffer state->fb may be NULL in nv50_wndw_prepare_fb(), so defer initializing nvbo from its obj[] array until after the NULL check. Signed-