Re: [Nouveau] [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-10-23 Thread Daniel Vetter
On Thu, Oct 01, 2020 at 08:46:59AM +1000, Ben Skeggs wrote: > On Wed, 30 Sep 2020 at 19:37, Daniel Vetter wrote: > > > > On Wed, Sep 30, 2020 at 10:45:05AM +1000, Ben Skeggs wrote: > > > On Wed, 30 Sep 2020 at 00:52, Daniel Vetter > > > wrote: > > > > > > > > On Thu, Sep 17, 2020 at 3:15 PM Dani

Re: [Nouveau] [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-30 Thread Ben Skeggs
On Wed, 30 Sep 2020 at 19:37, Daniel Vetter wrote: > > On Wed, Sep 30, 2020 at 10:45:05AM +1000, Ben Skeggs wrote: > > On Wed, 30 Sep 2020 at 00:52, Daniel Vetter wrote: > > > > > > On Thu, Sep 17, 2020 at 3:15 PM Daniel Vetter > > > wrote: > > > > > > > > Ben, did you have a chance to look at

Re: [Nouveau] [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-30 Thread Daniel Vetter
On Wed, Sep 30, 2020 at 10:45:05AM +1000, Ben Skeggs wrote: > On Wed, 30 Sep 2020 at 00:52, Daniel Vetter wrote: > > > > On Thu, Sep 17, 2020 at 3:15 PM Daniel Vetter > > wrote: > > > > > > Ben, did you have a chance to look at this? > > > > Ping > > -Daniel > > > > > On Mon, Aug 3, 2020 at 1:22

Re: [Nouveau] [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-29 Thread Ben Skeggs
On Wed, 30 Sep 2020 at 00:52, Daniel Vetter wrote: > > On Thu, Sep 17, 2020 at 3:15 PM Daniel Vetter wrote: > > > > Ben, did you have a chance to look at this? > > Ping > -Daniel > > > On Mon, Aug 3, 2020 at 1:22 PM Maarten Lankhorst > > wrote: > > > > > > Op 02-08-2020 om 20:18 schreef Daniel V

Re: [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-29 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 3:15 PM Daniel Vetter wrote: > > Ben, did you have a chance to look at this? Ping -Daniel > On Mon, Aug 3, 2020 at 1:22 PM Maarten Lankhorst > wrote: > > > > Op 02-08-2020 om 20:18 schreef Daniel Vetter: > > > Purely conjecture, but I think the original locking inversion

Re: [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-17 Thread Daniel Vetter
Ben, did you have a chance to look at this? -Daniel On Mon, Aug 3, 2020 at 1:22 PM Maarten Lankhorst wrote: > > Op 02-08-2020 om 20:18 schreef Daniel Vetter: > > Purely conjecture, but I think the original locking inversion with the > > legacy page flip code between flipping and ttm's bo move fun

Re: [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-08-03 Thread Maarten Lankhorst
Op 02-08-2020 om 20:18 schreef Daniel Vetter: > Purely conjecture, but I think the original locking inversion with the > legacy page flip code between flipping and ttm's bo move function > shoudn't exist anymore with atomic: With atomic the bo pinning and > actual modeset commit is completely separ

[PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-08-02 Thread Daniel Vetter
Purely conjecture, but I think the original locking inversion with the legacy page flip code between flipping and ttm's bo move function shoudn't exist anymore with atomic: With atomic the bo pinning and actual modeset commit is completely separated in the code patsh. This annotation was originall