In the for loop we are allocating the memory for rail everytime but
in some cases we use "continue" and in those cases the memory already
allocated for rail is leaked and we again allocate new memory for it.
Lets free the memory before continuing with the loop.
Signed-off-by: Sudip Mukherjee
---
Hi Colin,
thanks for pointing this out, but I am quite sure this continue
statement won't ever be hit, ever.
check the nvkm_iccsense_create_sensor function. A sensor object will
only be created for one of those three types and others don't exist.
I've just added that default statement to shut GCC
On 03/06/16 10:55, karol herbst wrote:
> Hi Colin,
>
> thanks for pointing this out, but I am quite sure this continue
> statement won't ever be hit, ever.
>
> check the nvkm_iccsense_create_sensor function. A sensor object will
> only be created for one of those three types and others don't exis
On 06/02/2016 08:28 PM, Colin King wrote:
> From: Colin Ian King
>
> The default sensor->type case leaks memory allocated to rail. Fix
> this by free'ing rail before we continue with the next loop iteration.
This doesn't completely fix the issue, as there are continue statements
in other sections
From: Colin Ian King
The default sensor->type case leaks memory allocated to rail. Fix
this by free'ing rail before we continue with the next loop iteration.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 1 +
1 file changed, 1 insertion(+)
diff --git