On Thu, Jul 13, 2023 at 11:13 AM Karol Herbst wrote:
>
> On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote:
> >
> > On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote:
> > > Fixed error: 'do not use assignment in if condition'
> > >
> > > This patch fixes error: 'do not use a
On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote:
>
> On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote:
> > Fixed error: 'do not use assignment in if condition'
> >
> > This patch fixes error: 'do not use assignment in if condition'
> > in drm/nouveau/iccsense
>
> I guess t
checkpatch.pl does not like assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/
On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote:
> Fixed error: 'do not use assignment in if condition'
>
> This patch fixes error: 'do not use assignment in if condition'
> in drm/nouveau/iccsense
I guess this is checkpatch fix, right?
>
> Signed-off-by: Ran Sun
> ---
>
Fixed error: 'do not use assignment in if condition'
This patch fixes error: 'do not use assignment in if condition'
in drm/nouveau/iccsense
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driv
In the for loop we are allocating the memory for rail everytime but
in some cases we use "continue" and in those cases the memory already
allocated for rail is leaked and we again allocate new memory for it.
Lets free the memory before continuing with the loop.
Signed-off-by: Sudip Mukherjee
---
Hi Colin,
thanks for pointing this out, but I am quite sure this continue
statement won't ever be hit, ever.
check the nvkm_iccsense_create_sensor function. A sensor object will
only be created for one of those three types and others don't exist.
I've just added that default statement to shut GCC
On 03/06/16 10:55, karol herbst wrote:
> Hi Colin,
>
> thanks for pointing this out, but I am quite sure this continue
> statement won't ever be hit, ever.
>
> check the nvkm_iccsense_create_sensor function. A sensor object will
> only be created for one of those three types and others don't exis
On 06/02/2016 08:28 PM, Colin King wrote:
> From: Colin Ian King
>
> The default sensor->type case leaks memory allocated to rail. Fix
> this by free'ing rail before we continue with the next loop iteration.
This doesn't completely fix the issue, as there are continue statements
in other sections
From: Colin Ian King
The default sensor->type case leaks memory allocated to rail. Fix
this by free'ing rail before we continue with the next loop iteration.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 1 +
1 file changed, 1 insertion(+)
diff --git
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL
check before freeing functions like kfree, debugfs_remove,
debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing f
> Martin Peres hat am 13. April 2016 um 09:55
> geschrieben:
>
>
> On 13/04/16 10:07, kbuild test robot wrote:
> > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL
> > check before freeing functions like kfree, debugfs_remove,
> > debugfs_remove_recursive or usb_free_
On 13/04/16 10:07, kbuild test robot wrote:
> drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL
> check before freeing functions like kfree, debugfs_remove,
> debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
> reorganizing relevant code to avoid pas
13 matches
Mail list logo
